Jump to:

10979 Posts in 2722 Topics by 1815 members

All other Modules

SilverStripe Forums » All other Modules » generic_views and 2.4.0 rc1

Discuss all other Modules here.

Moderators: martimiz, Sean, biapar, Willr, Ingo, swaiba, simon_w

Page: 1
Go to End
Author Topic: 865 Views
  • wildflower1975
    Community Member
    59 Posts

    generic_views and 2.4.0 rc1 Link to this post

    it appears Ticket #5278 is occurring on new collection page types

    I've installed 2.4.0 by removing the cms and sapphire directories and copying the new ones in.

    When creating a new standard page, and adding a link the Ticket #5278 is indeed closed/fixed.

    But when creating a new Collection Page and adding a link to the content block on the "Main" tab - I think this ticket shouldn't be closed or a new one opened?

    I can't tell where the error lies because the Collection Page just extends Page so surely a fix to Page would carry through?

  • Euphemismus
    Community Member
    82 Posts

    Re: generic_views and 2.4.0 rc1 Link to this post

    there is (as far as I found) one bug in the genericviews module. It's the deprecated ConfirmedFormAction() method call in line 114, called via $this->DeleteForm() in line 83 (genericviews/code/RecordController.php). Commenting out line 83 will at least prevent the module from crashing in 2.4rc1 ;-)
    And besides the functionality to delete, everything else worked fine again. This no fix, but a workaround.

  • Ingo
    Forum Moderator
    801 Posts

    Re: generic_views and 2.4.0 rc1 Link to this post

    I've replaced it with a normal FormAction for now, r104600. Fixed another bug in unit tests, but that should be it for 2.4 compatibility (all unit tests pass). Let me know if you have any further trouble.

  • Katy
    Community Member
    4 Posts

    Re: generic_views and 2.4.0 rc1 Link to this post

    Any ideas on how I might go about adding confirmation to the delete button?

    Also does anyone know why "ConfirmedFormAction" was removed in 2.4?

Page: 1
Go to Top

Want to know more about the company that brought you SilverStripe? Then check out SilverStripe.com

Comments on this website? Please give feedback.