Jump to:

10929 Posts in 2613 Topics by 1809 members

All other Modules

SilverStripe Forums » All other Modules » Newsletter - latest version github - subscription page

Discuss all other Modules here.

Moderators: martimiz, Sean, biapar, Willr, Ingo, swaiba, simon_w

Page: 1
Go to End
Author Topic: 299 Views
  • Kiwipearls
    Avatar
    Community Member
    34 Posts

    Newsletter - latest version github - subscription page Link to this post

    I really love the subscription page in the latest version on Github.

    But there is on error and I do not know how to fix.

    When a user submits the form to subscribe, the subscription completion page has a error with two <p> tags.

    I am so close to having this module working for my kid's school and would love to fix this tiny error but I do not know where to look.

    I very eagerly look forward to hearing from you - as I need this site finished before Easter.

  • Kiwipearls
    Avatar
    Community Member
    34 Posts

    Re: Newsletter - latest version github - subscription page Link to this post

    I found the fix

    newsletter/templates/Includes/SubscribeSubmission.ss

    change

    <% if FirstName %>$FirstName,<br ><% end_if %>

    <p>$OnCompleteMessage</p>

    to

    <% if FirstName %>$FirstName,<% end_if %>

    $OnCompleteMessage

  • Willr
    Avatar
    Forum Moderator
    5489 Posts

    Re: Newsletter - latest version github - subscription page Link to this post

    Would be great if you could submit that bugfix back to the github page so that it fixes it for everyone else if you haven't done it yet.

    299 Views
Page: 1
Go to Top

Want to know more about the company that brought you SilverStripe? Then check out SilverStripe.com

Comments on this website? Please give feedback.