Forum posts to 'Archive'

Re: Unigue URL Segment in SiteTree::write()

Andy — Tue, 07 Aug 2007 09:37:28 +1200

Thanks, I applied this!

Posted to: Unigue URL Segment in SiteTree::write() Show Thread | Post Reply

Re: Unigue URL Segment in SiteTree::write()

Sean — Mon, 06 Aug 2007 22:15:51 +1200

That sounds good to me. I guess it was a miss that it did what it was originally doing, with a number already in the URL segment. Andy, could you make sure this is patched in the main branch?

Sean

Posted to: Unigue URL Segment in SiteTree::write() Show Thread | Post Reply

Unigue URL Segment in SiteTree::write()

xmedeko — Mon, 06 Aug 2007 17:49:11 +1200

Hi,
I made a page "My 2nd Page" and my URLSegment was "my-2nd-page", then I have duplicated this page, and my URL segment has been changed to "mynd-page-2" (wrong). I made the patch:

--- SiteTree.php.orig   2007-08-06 17:48:37.000000000 +1200
+++ SiteTree.php   2007-08-06 17:47:06.000000000 +1200
@@ -419,7 +419,7 @@
      $count = 1;
      while(DataObject::get_one("SiteTree", "URLSegment = '$this->URLSegment' $idFilter")) {
         $count++;
-         $this->URLSegment = ereg_replace('-[0-9]+','', $this->URLSegment) . "-$count";
+         $this->URLSegment = ereg_replace('-[0-9]+$','', $this->URLSegment) . "-$count";
      }

      // If the URLSegment has been changed, rewrite links

And then duplication made URLSegment "my-2nd-page-2" (is that better?)

Posted to: Unigue URL Segment in SiteTree::write() Show Thread | Post Reply