17452 Posts in 4473 Topics by 1971 members
|Go to End||Next >|
26 November 2007 at 11:51am
During my translation testing and adding new translations on the newsletter, i attempted to create a newsletter subscription form page (on site content) to test the translations on subscribing/unsubscribing etc.
I though the form would be generated automatically, i.e. first, last name, email fields would be created without any user interaction, but they aren't.
What i did:
In Site Content i created a new page of 'Newsletter subscription form' type.
On the form tab, i specified to which newsletter to subscribe to, and the confirmation text.
Saved and published
On live site only the submit button shows up, no form fields.
Is it supposed that the user needs to make the fields ?
If not, must be a bug, already known ?
27 November 2007 at 12:21pm
Please i really need some help in this, as i'm trying to review/add translations to the newsletter part of CMS and i can't test this properly atm.
28 November 2007 at 8:32am
Hi, I've got quite the same problem. Have you create some field ? like as minimum an email field ?
From my side, the newsletter subscribtion form appears but when I'm sending the form, I don't receive any answer and the email is not subscribed ? any idea ?
I check the configuration and everything seems to be ok.
I think there is a small bug in the system. I hope it will be corrected in the final release.
28 November 2007 at 11:21am
Hehehe, the string TODO in SubscribeForm.php gave it away.
28 November 2007 at 4:00pm
Just make several testing on that page type and have an quick investigation of the code, it turns out that page type never works as it supposed to do.
The original design is: there are some default fields such as Email, FirstName, Surname will be populated every time when you created a page of this type in Form tab of the page, you can add/delete/edit fields based on those defaults, and some Field can't be delected. After save and publish, the form should work. But the default fields is not populated due to wrong judgement of if the page is a newly created page or an exsiting one. We need to fix this on our next release.
On the other hand, if you create fields called "Email", "FirstName", "Surname" by yourself, the form displays fine, just doesn't work when submit. This is due to customised fields need to have a parameter "CustomParameter" with the value of exactly the field name of member in DB. This is a bit pain, but this is how it is desiged to work. Unfornately, this CustomParameter can not be edited thru CMS (it is hidden under each fields in CMS). So this is another bug or bug-like.
I will talk to our CTO and create a open source task for this. Hopefully it could be solved in least time.
29 November 2007 at 7:44am
Thank you normann,
I tried to poke around SubscribeForm.php, trying at least to show the field which should be automatically added to the form, i noticed it was using addWithoutWrite. Tried to use push but, didn't work, also tried to search around how to do it in the source without success.
I guess i'll need to wait for that patch to text/translate the last 'module' i need to, Newsletters.
In the meanwhile i'll try on my spare time to go around file by file checking any string left out to translate.
30 November 2007 at 2:30pm Last edited: 30 November 2007 2:30pm
So... let's see if I'm understanding this correctly.
There's a whole section of the core CMS for newsletters, and a page type of "newsletter subscription form", but the form is broken and will never work (instead just displaying a "submit" button and nothing more), and adding your own e-mail, first / surname fields will not make it work.
...is that correct? And if so, isn't that a huge oversight..?
If not, how are users supposed to sign up to the newsletter without having to be added by an administrator?
3 December 2007 at 5:04am
yes, that's true darkowl, it is exactly the problem.
I'm a bit surprised that a so basic functionality has not been tested before ?
But I know that many efforts have been done for the silverstripe system. Thanks very much for that.
|Go to Top||Next >|