17488 Posts in 4473 Topics by 1978 members
|Go to End|
19 January 2008 at 5:29pm
couple points there jeff,
- You Current and Section highlighting for the menu 1 and menu 2.
- In the blog I would get rid of the icons next to the comment / read more or replace it with your own. They look wayy to web 2.0 for this design
- the comments have too much spacing around them. Get rid of that space and put a border or something between the comments instead to just tidy up that area.
Looks like a really interesting theme! Good work
Core Development Team
19 January 2008 at 6:22pm
When I look here:
I saw that when there are too many menu items, they go off the page. Can you make them wrap at the point where the box's edge is? Also, see if its possible for the box's height to increase to accomodate the extra menu items
I like this theme lots, so thanks very much for the grand effort of choosing this task of mine to do
19 January 2008 at 6:22pm
looks good apart from you missed my point #1
The theme meets all expectations so I have closed your task but feel free to keep updating it as per suggestions from users!
19 January 2008 at 9:53pm
Hey Jeff, great theme!
I have experianced the Sig's problem - the menu items are out of the box!
If I were you I would also consider some spacing between the menu items.
I can see no .current effect, too, in the primary menu.
As for the ecommerce, in the product page there are still some blue and green elements that look really weird...
As for the markup:
* following the SilverStripe guidelines is a good idea - in my themes I'm changing all the id names so they start with an uppercase, and the class first letters - to lowercase. That would be really nice if all the theme developers would do the same, as we're creating something that should be useful after the contest
Apart from that, your style is very nice! I'm looking forward to your next one
20 January 2008 at 5:04am Last edited: 20 January 2008 5:05am
Thanks to everyone for the feedback. You can download the new file from the directory.
@Will, sorry I missed your point.. (tired from finals). It's fixed now though.
@Siggy, I've made it so it wraps (not cut off)
@wojtek, I've made the capitalization (following the blankcandy usage) and fixed the colors in the ecommerce module.
20 January 2008 at 11:42am
I'm changing all the id names so they start with an uppercase, and the class first letters - to lowercase. That would be really nice if all the theme developers would do the same, as we're creating something that should be useful after the contest
Thank you wojtek!! we created CSS guidelines for a reason and its great people are taking them on board. Its something simple but if we have a consistent platform it will make SilverStripe look and feel more professional, and once you get into the habit to make IDs UpperCamelCase and class's lowerCamelCase its pretty easy to do.
|Go to Top|