Jump to:

17452 Posts in 4473 Topics by 1971 members

Archive

SilverStripe Forums » Archive » CurrencyField Format

Our old forums are still available as a read-only archive.

Moderators: martimiz, Sean, biapar, Willr, Ingo, simon_w

Page: 1
Go to End
Author Topic: 3472 Views
  • Aaron
    Avatar
    Community Member
    63 Posts

    CurrencyField Format Link to this post

    Hi there,
    I'm doing a custom sales solution and we are selling products that are available in 4 Currencies, US, UK, AUS and NZ
    I have added four CurrencyFields to the cms, however I notice that after saving, the default behavior is to put '$' symbols in the field.
    Am I able to change the currency format on a per-field basis?
    Also, what's the deal with validation? I am able to enter 'ddddfd' into any of these fields without an error being thrown.
    Cheers
    Aaron

  • zyko
    Avatar
    Community Member
    66 Posts

    Re: CurrencyField Format Link to this post

    subscribe...

    i wasn't even able to get the $ sign away globally... fe with €
    to get it on a 'format-field'-level would make things more right too..

  • Aaron
    Avatar
    Community Member
    63 Posts

    Re: CurrencyField Format Link to this post

    Well, It either isn't possible or we're simply not going to get an answer (probably both). I've found nada in my digging.

    I will be using a decimal field and hardcoding the currency format into it. (And definately not trusting silverstripe to take care of calculations - I will be POST-ing to standalone PHP pages for that.

  • Willr
    Avatar
    Forum Moderator
    5508 Posts

    Re: CurrencyField Format Link to this post

    Line 16 - 23 of Currency.php

       function Nice() {
          return '$' . number_format($this->value, 2);
       }
       
       function Whole() {
          return '$' . number_format($this->value, 0);
       }

    Try changing the $. I would assume this is where it is coming from!. You might like to abstract this out and submit is as a patch. It shouldnt be hardcoded in the core I would have thought

  • Double-A-Ron
    Avatar
    Community Member
    604 Posts

    Re: CurrencyField Format Link to this post

    Thanks Willr,

    I'll look into that but I'm outta time on this project now.

    I will look at the patch submission process, as ideally, I think this currency symbol is best tied to each field.

    Do you see a problem with passing the symbol as an argument? I'm a bit fresh in terms of what can be passed. I know that you can't pass variables as arguments.

    e.g.

    function Nice($symbol = '$') {
    return $symbol . number_format($this->value, 2);
    }

    function Whole($symbol = '$') {
    return $symbol . number_format($this->value, 0);
    }

  • Willr
    Avatar
    Forum Moderator
    5508 Posts

    Re: CurrencyField Format Link to this post

    hmm makes it interesting to have 2 different symbols on the same page. Passing it as an argument with a default might be the best / easiest way!

  • Ingo
    Avatar
    Forum Moderator
    801 Posts

    Re: CurrencyField Format Link to this post

    localization of dates/currencies etc is not implemented yet for silverstripe,
    but its pretty easy to subclass e.g. CurrencyField to return different formats for Nice() etc

    for validation, we're currently migrating to the jquery validate plugin, which should provide more solid (and already localized) clientside support.

    3472 Views
Page: 1
Go to Top

Want to know more about the company that brought you SilverStripe? Then check out SilverStripe.com

Comments on this website? Please give feedback.