Jump to:

17452 Posts in 4473 Topics by 1971 members

Archive

SilverStripe Forums » Archive » Patch: Usability Fix for Site Tree

Our old forums are still available as a read-only archive.

Moderators: martimiz, Sean, biapar, Willr, Ingo, simon_w

Page: 1 2
Go to End
Author Topic: 4760 Views
  • elijahlofgren
    Avatar
    Google Summer of Code Hacker
    222 Posts

    Patch: Usability Fix for Site Tree Link to this post

    Currently, the Left Frame is not very usable when large font sizes are used or when it is resized.

    This was mentioned in the Usability Report:
    "Users may be confused by the appearance of the left hand frame if they try to adjust its width. R: Make sure that the legibility of the frame contents is maximised when the frame width is adjusted."

    I have posted a link to the patch along with screenshots of the changes here:
    http://www.elijahlofgren.com/silverstripe/patches/sidebar-fix/sidebar-fix-patch-walkthrough.html

    I spent a long time trying to fix this many other ways (i.e. trying to just CSS changes), and finally found this solution which seems to be the best way to fix the problem.

    I hope you find this helpful,

    Elijah

  • Sam
    Avatar
    Administrator
    679 Posts

    Re: Patch: Usability Fix for Site Tree Link to this post

    Great work on this - thanks for the very thorough explanation of the issue

  • Sam
    Avatar
    Administrator
    679 Posts

    Re: Patch: Usability Fix for Site Tree Link to this post

    This has been merged into the stable branch, and will appear in the nightly builds soon.

  • Tim
    Avatar
    Core Development Team
    201 Posts

    Re: Patch: Usability Fix for Site Tree Link to this post

    You're the patch master

    Keep up the great work!

  • Andy
    Avatar
    230 Posts

    Re: Patch: Usability Fix for Site Tree Link to this post

    This seems to have broken the tree in all the other sections. Can you have a look at this Elijah?

  • elijahlofgren
    Avatar
    Google Summer of Code Hacker
    222 Posts

    Re: Patch: Usability Fix for Site Tree Link to this post

    Hi Andy,

    I'll try to look into it soon. I need to switch over to the SVN version first.

    - Elijah

    Update: Night draws near. I'll try to investigate further tomorrow. If I don't get to it tomorrow, it may not be until June 6th when I will get to it because I have a family reunion from June 1st to 4th and most people are not leaving until June 5th.

  • elijahlofgren
    Avatar
    Google Summer of Code Hacker
    222 Posts

    Re: Patch: Usability Fix for Site Tree Link to this post

    Adding:
    "height: 23px;"
    back to cms/css/cms_left.css fixes the problem of the other sections being broken. The only downside is that there is a different background color behind some of the links when the left frame's size is reduced. That's not a problem.

    I'll plan on eventually creating a new patch that addresses the "Site Content", "Newsletters", and "Security" sections. However, if you want to fix the Site Content without breaking the other sections, just uncomment "height: 23px;"
    in cms/css/cms_left.css

    Until later,

    Elijah

  • Sean
    Avatar
    Forum Moderator
    921 Posts

    Re: Patch: Usability Fix for Site Tree Link to this post

    Yeah, the background missing is caused by <li> elements having the float: left CSS attribute, and the container <ul> doesn't have this - so the background contents gets erased. If you add float: left to the <ul> it fixes that problem, but the other sections are still broken - this potentially could take a while to fix properly.

    Cheers,
    Sean

    4760 Views
Page: 1 2
Go to Top

Want to know more about the company that brought you SilverStripe? Then check out SilverStripe.com

Comments on this website? Please give feedback.