17488 Posts in 4473 Topics by 1978 members
| Go to End | ||
| Author | Topic: | 4487 Views |
-
Re: Patch: Usability Fix for Site Tree

1 June 2007 at 1:49pm
Sean, Thanks! I was able to get the background color to work correctly by floating the ul left.
Andy, I've created an updated patch that fixes the resizing issue for "Site Content", "Files & Images", "Newsletters", and "Security" (those are the only sections that I have on my install).
During my testing, this new patch worked flawlessly in Firefox 2, IE 6, and IE 7 for each of the sections.
Patch (not indented for clarity of seeing what I changed):
http://www.elijahlofgren.com/silverstripe/patches/sidebar-fix/Fix-sidebar-resizing-problems-non-indented-trunk-r36331.patch
Patch with indentation adjusted:
http://www.elijahlofgren.com/silverstripe/patches/sidebar-fix/Fix-sidebar-resizing-problems-indented-trunk-r36331.patchLet me know if you find any issues. I'll be busy with my family reunion starting tomorrow so I may not be able to respond until June 5th or 6th. ;)
Thanks,
Elijah
-
Re: Patch: Usability Fix for Site Tree

1 June 2007 at 9:15pm Last edited: 1 June 2007 9:17pm
Awesome work Elijah.
I think if you have 'float: left' or 'float: right' elements inside a container element, the container (in standards browsers) has no height, resulting in losing backgrounds, and it's normal block level behaviour. This is the opposite in IE, ironically.
I've already compiled a small list of issues, separate of the Optimal Usability guide that we can probably accomplish. However, that guide in itself does outline a large portion of work to be done.
I'll be in touch next week,
Cheers,
Sean -
Re: Patch: Usability Fix for Site Tree

6 June 2007 at 10:20am
Hi Sean,
> Awesome work Elijah.
Thanks.
> I've already compiled a small list of issues, separate of the Optimal Usability guide that we can probably accomplish. However, that guide in itself does outline a large portion of work to be done.
> I'll be in touch next week,Great, I look forward to hearing from you.
Until I hear from you, I will begin working on some of the "Critical" issues identified in the Usability report beginning with "#63 'Create new draft' button should be shown when 'Drafts' is clicked":
http://www.elijahlofgren.com/silverstripe/usability-to-do-list/#63If I get that one done before I hear from you, I may start on "#48 Delete and Move Files buttons need repositioning".
Let me know if I should increase the priority of any of the issues.
I look forward to hearing from you,
Elijah
-
Re: Patch: Usability Fix for Site Tree

9 June 2007 at 2:51pm
> This seems to have broken the tree in all the other sections. Can you have a look at this
Here is a patch that fixes the left frame resizing issues for the 'Files & Images', 'Newsletters', and 'Security' sections:
http://www.elijahlofgren.com/silverstripe/patches/sidebar-fix/Fix-sidebar-resizing-problems-indented-cms-gsoc-r36620.patchI have applied this patch to the gsoc branch of cms in SVN revision 36623.
I'm marking "#10 Left Frame Legibility when width adjusted" as complete:
http://www.elijahlofgren.com/silverstripe/left-frame-legibility-when-width-adjusted/Let me know if you find any more problems.
Thanks,
Elijah
-
Re: Patch: Usability Fix for Site Tree

11 June 2007 at 10:19am
Ok I've merged this into the main branch. Thanks!
| 4487 Views | ||
| Go to Top |



