Jump to:

17452 Posts in 4473 Topics by 1971 members

Archive

SilverStripe Forums » Archive » Admin Tab Heights Increased - request for feedback

Our old forums are still available as a read-only archive.

Moderators: martimiz, Sean, biapar, Willr, Ingo, simon_w

Page: 1
Go to End
Author Topic: 2355 Views
  • elijahlofgren
    Avatar
    Google Summer of Code Hacker
    222 Posts

    Admin Tab Heights Increased - request for feedback Link to this post

    Hi guys,

    Today I worked on "Make HTML editor full height of window (if possible)" as part of usability issue #57 "Newsletter tree and tab row are confusing": http://www.elijahlofgren.com/silverstripe/newletter-tree-and-tab-row-are-confusing/

    To increase the height of the Admin Tabs, and therefore allow the editor to expand to the full height of the browser, I committed this change to the gsoc branch of jsparty:
    http://www.elijahlofgren.com/silverstripe/patches/Usability-Issue-57-Increase-Tab-Height-jsparty-gsoc-r36716.patch

    Here are the results in Firefox 2, Internet Explorer 7, and IE6:
    http://www.elijahlofgren.com/silverstripe/images/usability/57-tab-height-before-after-screenshots.html

    As you can see, I was only able to get the best spacing in Firefox 2.

    I'd love your feedback and suggestions regarding this change.

    I have marked this usability issue as complete, but will look at it again if you find something that needs changing.

    Thanks,

    Elijah Lofgren

  • qhoxie
    Avatar
    Google Summer of Code Hacker
    39 Posts

    Re: Admin Tab Heights Increased - request for feedback Link to this post

    for the time being, i would call it a success
    it seems like everything is extended sufficiently

    if you have free time late in the summer (not that you will), you could play with some js and/or css hacks to make things more consistent, but it probably is not worth the time right now

  • Tim
    Avatar
    Core Development Team
    201 Posts

    Re: Admin Tab Heights Increased - request for feedback Link to this post

    I think it would be great if there was a "maximise" button, which could toggle the WYSIWYG window, so that it would take up the entire right hand content window (ie so you can't see any of their other fields).

  • Willr
    Avatar
    Forum Moderator
    5508 Posts

    Re: Admin Tab Heights Increased - request for feedback Link to this post

    Elijah - great patch man its wicked. Sean will be able to help you if you want to get IE6/7 working the same as FF2. But it doesnt really seem a huge deal it looks good enough!

    "I think it would be great if there was a "maximise" button, which could toggle the WYSIWYG window, so that it would take up the entire right hand content window"

    You could go further and do something like a maximize button or something that loads the content area into like a light box window that takes up 95% of the screen space. I think that would be pretty cool as when you are trying to write content you dont normally need to see the site tree or the top tabs or anything else apart from the tiny MCE controls which would be embeded in the lightbox window. Then when you click save/publish or a Minimize button is goes back to the old self

  • Markus
    Avatar
    Google Summer of Code Hacker
    152 Posts

    Re: Admin Tab Heights Increased - request for feedback Link to this post

    Hey!

    I think that small difference in the browsers is not so important. From a usability-viewpoint in my opinion there is a much more important thing:

    When the content textarea gets larger, the scrollbar doesn't appear on the textarea (where it should), but on the tab. This is an unnatural behavior which users may not understand. Another drawback is that in that way the page name and the navigational label fields will disappear when the user scrolls down.

    Maybe you should address this issue instead of trying to make a pixel-perfect layout in all major browsers.

  • elijahlofgren
    Avatar
    Google Summer of Code Hacker
    222 Posts

    Re: Admin Tab Heights Increased - request for feedback Link to this post

    > "I think it would be great if there was a "maximise" button, which could toggle the WYSIWYG window, so that it would take up the entire right hand content window"

    > You could go further and do something like a maximize button or something that loads the content area into like a light box window that takes up 95% of the screen space. I think that would be pretty cool as when you are trying to write content you dont normally need to see the site tree or the top tabs or anything else apart from the tiny MCE controls which would be embeded in the lightbox window. Then when you click save/publish or a Minimize button is goes back to the old self

    When you suggested this, I immediately thought of the TinyMCE fullscreen plugin.

    You can try it out by going to http://tinymce.moxiecode.com/example_full.php and clicking the "Toggle Fullscreen mode" button (last button on the right in the the 3rd row).

    I spent about 30 minutes today trying to get it to work in SilverStripe, but didn't get very far. The main thing I found was that to make the fullscreen button show on the SilverStripe TinyMCE toolbar, this line needs to be added to sapphire/forms/HtmlEditorField.php:
    new HtmlEditorField_button("mceFullScreen","fullscreen","Toggle Full Screen Mode"),

    However, the fullscreen plugin does not work correctly.

    >> When the content textarea gets larger, the scrollbar doesn't appear on the textarea (where it should), but on the tab. This is an unnatural behavior which users may not understand. Another drawback is that in that way the page name and the navigational label fields will disappear when the user scrolls down.

    I agree that this is unnatural. However, because it would be such a large change to the way the SilverStripe currently works, I'm reluctant to look into changing it.

    Does anyone else thing this needs changing?

  • Tim
    Avatar
    Core Development Team
    201 Posts

    Re: Admin Tab Heights Increased - request for feedback Link to this post

    The full screen mode is nice, however it's unlikely we will be able to use this plug-in out of the box, as as we've needed to hack up TinyMCE quite a bit to make it do what we want it to (specifically the separation of the top tool bar from the content area)

    However I think replicating this functionality would be time well spent.

  • Sam
    Avatar
    Administrator
    679 Posts

    Re: Admin Tab Heights Increased - request for feedback Link to this post

    The reason we had the scroll bar on the tab rather than the text field was in situations where you have several fields as well as a HTMLEditorField on a single tab - maybe even multiple HTMLEditorFields on a single tab.

    If we put the scrollbar onto the TinyMCE window, you would risk getting a mess of scrollbars; it also means that you can't scroll down to hide the title and see more of the TinyMCE content.

    I think that I would want to see evidence of users getting confused by this before acting on changes to the scrollbar position.

    2355 Views
Page: 1
Go to Top

Want to know more about the company that brought you SilverStripe? Then check out SilverStripe.com

Comments on this website? Please give feedback.