Jump to:

17452 Posts in 4473 Topics by 1971 members

Archive

SilverStripe Forums » Archive » Moving the 'Delete' and 'Move Files' buttons

Our old forums are still available as a read-only archive.

Moderators: martimiz, Sean, biapar, Willr, Ingo, simon_w

Page: 1 2 3
Go to End
Author Topic: 53595 Views
  • elijahlofgren
    Avatar
    Google Summer of Code Hacker
    222 Posts

    Moving the 'Delete' and 'Move Files' buttons Link to this post

    I hit a lot of dead ends trying to figure out a way to move the 'Delete' and 'Move Files' buttons in the 'Files & Images' section in order to fix critical usability issue #48 "Delete and Move Files buttons need repositioning"

    Then tonight I found out that I could use appendChild() to easily move any element, anywhere: http://www.elijahlofgren.com/silverstripe/diffs/Usability-48-reposition-delete-and-move-files-buttons-example-concept-cms-gsoc-36933.diff

    If I cleaned up the code and made it only apply to the 'Files & Images' section, what would you think about a button placement similar to the screen shots posted here?
    http://www.elijahlofgren.com/silverstripe/delete-and-move-files-buttons-need-repositioning/

    What is the best way to fix this usability issue?

    Thank you for your help,

    Elijah Lofgren

  • elijahlofgren
    Avatar
    Google Summer of Code Hacker
    222 Posts

    Re: Moving the 'Delete' and 'Move Files' buttons Link to this post

    Today I spent a long time trying to fix this in a better way, and I think I may have succeeded.

    Changes are a net loss of code
    http://www.elijahlofgren.com/silverstripe/patches/Fix-Usability-Issue-48-delete-and-move-files-buttons-need-repositioning-cms-gsoc-r37498.patch

    Screenshot showing new button & move file dropdown location:
    http://www.elijahlofgren.com/silverstripe/images/usability/48-fixed.png

    Do you think this is a good way to fix this usability issue?

    If so, I will apply it to the gsoc branch.

    Eagerly awaiting your feedback,

    Elijah

  • Sean
    Avatar
    Forum Moderator
    921 Posts

    Re: Moving the 'Delete' and 'Move Files' buttons Link to this post

    I think that's good. I guess the idea is to ensure, as you've always previously done - is to check that it works consistently across different browsers.

    It's good that you've positioned the save button there, now that the other action buttons were moved to the bottom right as well on other sections of the CMS. Is it possible to right align those 'Delete...' and 'Move...' buttons and dropdowns to the right, for a bit more consistency?

    I'm not sure positioning them right would be the best idea in terms of usability, but to me it would be easier to group any action buttons together, rather than have some on the left, and one on the right. Perhaps someone else has a suggestion here?

    > Changes are a net loss of code

    Fantastic work.

  • elijahlofgren
    Avatar
    Google Summer of Code Hacker
    222 Posts

    Re: Moving the 'Delete' and 'Move Files' buttons Link to this post

    > I think that's good. I guess the idea is to ensure, as you've always previously done - is to check that it works consistently across different browsers.

    I'll plan on doing that.

    > It's good that you've positioned the save button there, now that the other action buttons were moved to the bottom right as well on other sections of the CMS. Is it possible to right align those 'Delete...' and 'Move...' buttons and dropdowns to the right, for a bit more consistency?

    I agree that the way they were left aligned was not optimal. I was going to suggest also moving both the buttons and the checkboxes to the right, but then I did some searching and found that checkboxes on the left is pretty much a standard.

    > I'm not sure positioning them right would be the best idea in terms of usability, but to me it would be easier to group any action buttons together, rather than have some on the left, and one on the right. Perhaps someone else has a suggestion here?

    I've done a mockup of what I think is a better design. Everything is now on one line, and it gives more room for the folder drop-down:
    http://www.elijahlofgren.com/silverstripe/images/usability/48-better-mockup.png

    I think this layout is more usable and also allows for a more logical move file process. 1. Go down the row checking the boxes. 2. Move mouse to the right and choose folder (instead of skipping over "Delete files" button as before". 3. Continue moving mouse right and click "Move files" (instead of moving back to the left).

    In addition, the more dangerous "Delete files" button is made less prominent by right aligning it. I'll also plan to make the background of "Delete files" red on hover.

    What do you think of this new mockup?

    Thanks,

    Elijah

  • Sam
    Avatar
    Administrator
    679 Posts

    Re: Moving the 'Delete' and 'Move Files' buttons Link to this post

    One suggestion I would make is renaming "Save" to "Save folder name" or something. People are often confused about what that save button is for - it doesn't actually do anything to the folder contents!

  • Tim
    Avatar
    Core Development Team
    201 Posts

    Re: Moving the 'Delete' and 'Move Files' buttons Link to this post

    With the deletion of files, why don't we just have a "delete" icon in a column along side the edit icon? I think this is more inductive / standard than the check box solution.

  • elijahlofgren
    Avatar
    Google Summer of Code Hacker
    222 Posts

    Re: Moving the 'Delete' and 'Move Files' buttons Link to this post

    > One suggestion I would make is renaming "Save" to "Save folder name" or something. People are often confused about what that save button is for - it doesn't actually do anything to the folder contents!

    Indeed! In addition, I will make the "Save folder name" button not show for the root folder since "assets" cannot be renamed. Having a useless save button there doesn't help things. ;)

    > With the deletion of files, why don't we just have a "delete" icon in a column along side the edit icon? I think this is more inductive / standard than the check box solution.

    Would we then remove the option to delete multiple files at once? Or would this be an addition of functionality?

  • Tim
    Avatar
    Core Development Team
    201 Posts

    Re: Moving the 'Delete' and 'Move Files' buttons Link to this post

    I suggest we replace the check box solution entirely for the deletion of files. As along as we make the deletion "Ajax-y" there won't be any performance issues for the deletion of multiple files. In most situations however, people will only be deleting one or two files so I don't think we need to be overly concerned about this regardless.

    53595 Views
Page: 1 2 3
Go to Top

Want to know more about the company that brought you SilverStripe? Then check out SilverStripe.com

Comments on this website? Please give feedback.