Jump to:

17452 Posts in 4473 Topics by 1971 members

Archive

SilverStripe Forums » Archive » Tree control tweaks

Our old forums are still available as a read-only archive.

Moderators: martimiz, Sean, biapar, Willr, Ingo, simon_w

Page: 1 2
Go to End
Author Topic: 6358 Views
  • Sigurd
    Avatar
    Forum Moderator
    628 Posts

    Re: Tree control tweaks Link to this post

    So, Elijah, is this committed to SVN now ya mean?

  • Sigurd
    Avatar
    Forum Moderator
    628 Posts

    Re: Tree control tweaks Link to this post

    So, Elijah, is this committed to SVN now ya mean?

  • elijahlofgren
    Avatar
    Google Summer of Code Hacker
    222 Posts

    Re: Tree control tweaks Link to this post

    > So, Elijah, is this committed to SVN now ya mean?
    Yes.

    Here's my commit message to the gsoc branch of jsparty:
    ------------------------------------------------------------------------
    r37261 | elofgren | 2007-06-21 21:19:00 -0500 (Thu, 21 Jun 2007) | 8 lines

    Merge Site Tree Tweaks from Steve (excluding minor formatting changes). Changes:
    1. Optimizations: a) Don't process a node if already done. b) Don't "Find last div before first ul"
    2. New treeCloseAll() and treeOpenAll() functions.
    3. Code documentation improvements.
    SKIPPED: Merging code for: "Check for head/meta name='render-spans'. If present, don't call (slow) initTrees". Reason: initTree() no longer exists and I can't find a function that matches it
    close enough to merge this code.
    More info: http://www.silverstripe.com/contributions/flat/1611

    ------------------------------------------------------------------------

  • Andy
    Avatar
    230 Posts

    Re: Tree control tweaks Link to this post

    Looks good, merged into main branch. Thanks to both of you.

  • bbodien
    Avatar
    2 Posts

    Re: Tree control tweaks Link to this post

    Hi guys,

    Is the GSoC branch available anywhere? I'd really like to test out the modified tree.js, as I'm having some performance issues with largeish structures, particularly in IE6.

    Thanks!

  • elijahlofgren
    Avatar
    Google Summer of Code Hacker
    222 Posts

    Re: Tree control tweaks Link to this post

    > Is the GSoC branch available anywhere? I'd really like to test out the modified tree.js, as I'm having some performance issues with largeish structures, particularly in IE6.

    Hi bbodien,

    The GSoC branch is currently not publicly available (coming soon hopefully).

    Here are two different versions of Steve's Tree control tweaks patches (in case you'd like to see the changes):
    Steves-Site-Tree-Tweaks-fixed-whitespace.diff
    Steves-Site-Tree-Tweaks-in-universal-format.diff

    Here is the original tree control file: tree-original.js
    And here is the version of it with the above changes applied: tree-patched.js

    However, the tree.js used in the gsoc branch is very different from the one available at http://www.silverstripe.com/tree-control/ so only these changes were applied: Site-Tree-Tweaks-gsoc-r37261.patch
    I'm guessing that the current gsoc version might be too different to use, but here it is in case it is useful: tree-gsoc-r37735.js

    Hope this helps,

    Elijah Lofgren

  • bbodien
    Avatar
    2 Posts

    Re: Tree control tweaks Link to this post

    Elijah,

    Many thanks for the patched versions. I'll try them out as soon as I can. Best of luck with the GSoC project, I've just been reading about it with interest on the silverstripe rss feed.

    Ben

    6358 Views
Page: 1 2
Go to Top

Want to know more about the company that brought you SilverStripe? Then check out SilverStripe.com

Comments on this website? Please give feedback.