Jump to:

17452 Posts in 4473 Topics by 1971 members

Archive

SilverStripe Forums » Archive » branches/2.0 merged into branches/gsoc

Our old forums are still available as a read-only archive.

Moderators: martimiz, Sean, biapar, Willr, Ingo, simon_w

Page: 1 2
Go to End
Author Topic: 2366 Views
  • Sam
    Avatar
    Administrator
    679 Posts

    Re: branches/2.0 merged into branches/gsoc Link to this post

    "Why not just make a file _manifest_exclude which can also be a zero-byte file. There is no need for a specific file format since the file itself doesn't contains any information."

    I think we're in agreement. Markus, can you please add support for _manifest_exclude files and revert my XML.php filename change when it's convenient.

  • Markus
    Avatar
    Google Summer of Code Hacker
    152 Posts

    Re: branches/2.0 merged into branches/gsoc Link to this post

    Perfect, I created a ticket for that...

  • Markus
    Avatar
    Google Summer of Code Hacker
    152 Posts

    Re: branches/2.0 merged into branches/gsoc Link to this post

    ... and implemented it

    The change of the manifest builder is in r38451 (added also some docBlocks, so please review the changes).

    Sam's changes to the OpenID library are reverted in r38452, so it is now again in it's original version and it's easy to update it.

  • Markus
    Avatar
    Google Summer of Code Hacker
    152 Posts

    Re: branches/2.0 merged into branches/gsoc Link to this post

    @Sam:

    There was a serious bug in Object::addStaticVars() which I fixed in r38453.

    If DataObject::add_extension() was used more than once per class, previously the extensions were overwritten and so only the last one was usable.

  • Sam
    Avatar
    Administrator
    679 Posts

    Re: branches/2.0 merged into branches/gsoc Link to this post

    Thanks for that, Markus!

    2366 Views
Page: 1 2
Go to Top

Want to know more about the company that brought you SilverStripe? Then check out SilverStripe.com

Comments on this website? Please give feedback.