Jump to:

17452 Posts in 4473 Topics by 1971 members

Archive

SilverStripe Forums » Archive » Exclude tests from the standard "stable download"

Our old forums are still available as a read-only archive.

Moderators: martimiz, Sean, biapar, Willr, Ingo, simon_w

Page: 1 2
Go to End
Author Topic: 3017 Views
  • Markus
    Avatar
    Google Summer of Code Hacker
    152 Posts

    Exclude tests from the standard "stable download" Link to this post

    I would suggest to exclude the test files (sapphire/selenium, sapphire/simpletest, and maybe also sapphire/tests) of the standard download since most users won't ever use or need those files and it would save some bandwidth and storage and speed up a little bit the manifest building.

    This would reduce the size of the download (v2.0.2b) from 2.03 MB to approx. 1.80 and save almost 1 MB after unpacking it.

    What do you think about this idea? Nevertheless you could offer a separate archive with those test files.

  • Sean
    Avatar
    Forum Moderator
    921 Posts

    Re: Exclude tests from the standard "stable download" Link to this post

    Sounds like a reasonable plan to me. Anything to get the download more lightweight is worth doing, especially when such files are not being used that often.

    Cheers!
    Sean

  • Andy
    Avatar
    230 Posts

    Re: Exclude tests from the standard "stable download" Link to this post

    I'm not sure these tests are even used.. I'll check with Sam and see if we can just remove them completely.

  • Sam
    Avatar
    Administrator
    679 Posts

    Re: Exclude tests from the standard "stable download" Link to this post

    They're currently not used as part of our build process. We're going to be setting up a suite of tests based on PHPUnit shortly.

    Until there are more than a couple of test files, I think that removing them from the distribution is premature optimisation. You'd get a lot more mileage, for instance, in removing the TinyMCE plug-ins / languages that we don't use!

  • xmedeko
    Avatar
    Community Member
    94 Posts

    Re: Exclude tests from the standard "stable download" Link to this post

    Can you make the these PHPUnit tests (or some usable core of them) also public, after you set up them?
    Thanks

  • Willr
    Avatar
    Forum Moderator
    5489 Posts

    Re: Exclude tests from the standard "stable download" Link to this post

    removing the TinyMCE plug-ins / languages that we don't use!

    ooh please do .. I really hate ftping tiny_mce!!

  • Sean
    Avatar
    Forum Moderator
    921 Posts

    Re: Exclude tests from the standard "stable download" Link to this post

    If we're not using something, why should it be in there? Especially if it reduces the file size of the download by a couple of hundred KB. Sam, will we be removing these eventually in favour of PHPUnit or keeping them in there?

    Having TinyMCE more modular would be helpful. That massive batch of language support files is irritating to say the least when uploading via FTP. Agreed Will!

    Cheers,
    Sean

  • Markus
    Avatar
    Google Summer of Code Hacker
    152 Posts

    Re: Exclude tests from the standard "stable download" Link to this post

    > You'd get a lot more mileage, for instance, in removing the TinyMCE plug-ins /
    > languages that we don't use!

    > If we're not using something, why should it be in there?
    > Especially if it reduces the file size of the download by a couple of hundred KB.

    Well, I think it would be also a good idea to remove the unused TinyMCE plug-ins but since Bernat is working on localization of the whole system in my opinion it would be a step backwards by removing the language files.

    Another important aspect is that by removing unused files we not only reduce the file size but also the attack surface!

    3017 Views
Page: 1 2
Go to Top

Want to know more about the company that brought you SilverStripe? Then check out SilverStripe.com

Comments on this website? Please give feedback.