Jump to:

17452 Posts in 4473 Topics by 1971 members

Archive

SilverStripe Forums » Archive » Bug in TinyMCE2

Our old forums are still available as a read-only archive.

Moderators: martimiz, Sean, biapar, Willr, Ingo, simon_w

Page: 1 2
Go to End
Author Topic: 4406 Views
  • Markus
    Avatar
    Google Summer of Code Hacker
    152 Posts

    Bug in TinyMCE2 Link to this post

    There is a bug in TinyMCE which makes it unusable for IE. I attached a patch since I have not the rights to commit to the TinyMCE code... I also filed the issue at their Sourceforge tracker

    Patch:

    Index: tiny_mce_src.js
    ===================================================================
    --- tiny_mce_src.js   (revision 39628)
    +++ tiny_mce_src.js   (working copy)
    @@ -1571,7 +1571,7 @@
             return;
          }

    -      if (tinyMCE.isRealIE && window.event.type == "readystatechange" && document.readyState != "complete")
    +      if (tinyMCE.isRealIE && window.event && window.event.type == "readystatechange" && document.readyState != "complete")
             return true;

          if (tinyMCE.isLoaded)

  • Markus
    Avatar
    Google Summer of Code Hacker
    152 Posts

    Re: Bug in TinyMCE2 Link to this post

    Thanks for patching it Andy.

  • elijahlofgren
    Avatar
    Google Summer of Code Hacker
    222 Posts
  • Markus
    Avatar
    Google Summer of Code Hacker
    152 Posts

    Re: Bug in TinyMCE2 Link to this post

    No problem I didn't look at those tickets but yes, it should fix both issues.

    There is another javascript bug (at least in IE7):
    The confirmation dialog ("Are you sure you want to navigate away from this page...") appears also if no changes where made.

    There was somewhere a discussion about that but I can't find it.. have you an idea where the bug resides Elijah? Otherwise I'll open a ticket for it.

  • elijahlofgren
    Avatar
    Google Summer of Code Hacker
    222 Posts

    Re: Bug in TinyMCE2 Link to this post

    > There is another javascript bug (at least in IE7):
    The confirmation dialog ("Are you sure you want to navigate away from this page...") appears also if no changes where made.
    > There was somewhere a discussion about that but I can't find it.. have you an idea where the bug resides Elijah? Otherwise I'll open a ticket for it.

    I think this is the bug you are looking for: Ticket #1372 - Change Detection Broken in TinyMCE 2.1.1.1 cause Confirm dialogue every time page is edited

  • Markus
    Avatar
    Google Summer of Code Hacker
    152 Posts

    Re: Bug in TinyMCE2 Link to this post

    Right.. I'm talking about that bug.. are you already working on it Elijah?
    At the moment I'm busy but I could help you by the end of next week..

  • elijahlofgren
    Avatar
    Google Summer of Code Hacker
    222 Posts

    Re: Bug in TinyMCE2 Link to this post

    > Right.. I'm talking about that bug.. are you already working on it Elijah?

    No, I'm not. I did find a hack to work around the problem though: http://open.silverstripe.com/attachment/ticket/1372/Hack-To-Fix-TinyMCE-Change-Detection-cms-gsoc-r38861.diff

    > At the moment I'm busy but I could help you by the end of next week..

    It'd be great if you would work on this. This bug is quite annoying, and I don't enjoy working on TinyMCE very much. ;)

  • Markus
    Avatar
    Google Summer of Code Hacker
    152 Posts

    Re: Bug in TinyMCE2 Link to this post

    OK, I'll see what I can do.. I plan to work on this on Friday.. so if you find a solution or more information about this bug in the meantime tell me!

    4406 Views
Page: 1 2
Go to Top

Want to know more about the company that brought you SilverStripe? Then check out SilverStripe.com

Comments on this website? Please give feedback.