Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

All other Modules

Discuss all other Modules here.

Moderators: martimiz, Sean, biapar, Willr, Ingo, swaiba, simon_w

UserForms stays green after publishing


Reply

7 Posts   1296 Views

Avatar
Terry Apodaca

7 March 2011 at 1:13pm Community Member, 109 Posts

I know this is probably trivial to most, but it's really bugging my client. I can reproduce this in just about every install I have...after the initial install, and after you make a modification the first time...the Tree item stays green. I've tried everything, and it will always stay green.

Has anyone else seen this?

Avatar
Ryan M.

9 March 2011 at 8:53pm Community Member, 309 Posts

I have, and it bugs me too, although not as much.

Avatar
Willr

9 March 2011 at 10:28pm Forum Moderator, 5511 Posts

It will always be green as SS 2.4 + workflow introduced a great feature as if it doesn't detect any changes to the page then it won't create a new version or publish it. But for UserForms I haven't got round to building change detection as it involves a number of components.

If anyone wants to get stuck into fixing it I would be most grateful. The specific function is https://github.com/silverstripe/silverstripe-userforms/blob/master/code/UserDefinedForm.php#L282

Avatar
Terry Apodaca

10 March 2011 at 8:03am Community Member, 109 Posts

if I can get some time, I might look at fixing this, just because it's bugging my client.

It's not a big deal to me though...since it's known and not really hindering the functionality of the module.

Avatar
purplespider

26 January 2012 at 3:09am Community Member, 81 Posts

Just wondering if anyone had a stab at this? I've now got a client complaining about it too!

Avatar
Terry Apodaca

26 January 2012 at 6:39am Community Member, 109 Posts

I wouldn't worry about it, as SS3 is around the corner....just ask your clients to deal with it for now.

Avatar
Willr

8 February 2012 at 9:47pm Forum Moderator, 5511 Posts

You could change this to return false and it will stay black (instead of green) https://github.com/silverstripe/silverstripe-userforms/blob/master/code/UserDefinedForm.php#L282.

If anyone has the time to get the detection working would be good to have, it'll have to track form field updates, setting changes (could just use a parent:: getIsModifiedOnStage() for that) and email submission updates (which aren't versioned) against the latest published date.