Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

All other Modules

Discuss all other Modules here.

Moderators: martimiz, Sean, biapar, Willr, Ingo, swaiba, simon_w

Image Gallery Extension: Testers Needed


Reply

417 Posts   78054 Views

Avatar
Joshuarr

16 December 2008 at 6:09pm Community Member, 37 Posts

Uncle Cheese,

I'm reviving this thread and hope you see it.

I tried the modifications you made:

Please make the following fixes and let me know the result.

/image_gallery/code/ImageGalleryAlbum.php : line 88
Change
if($_POST['Source'] == "new") {
to
if(isset($_POST['Source']) && $_POST['source'] == "new") {

/sapphire/core/model/Image.php : line 634
Change
if($data['ImageSource'] != 'existing' && $data['Upload']['size'] == 0) {
to
if(isset($data['ImageSource']) && $data['ImageSource'] != 'existing' && $data['Upload']['size'] == 0) {

/gallery/code/GalleryPage.php : line 381
Change
if( ! is_numeric( $_REQUEST['start'] ) )
to
if(isset($_REQUEST['start']) && ! is_numeric( $_REQUEST['start'] ) )

Now I get this error when visiting the default album on a newly created image gallery page :

Notice: Undefined index: start in /Users/LabBrain/Sites/JR/gallery/code/GalleryPage.php on line 383

FATAL ERROR: DATABASE ERROR: Couldn't run query: SELECT `File`.ID, `File`.ClassName, `File`.Created, `File`.LastEdited, `File`.Name, `File`.Title, `File`.Content, `File`.ParentID, `File`.Filename, if(`File`.ClassName,`File`.ClassName,'File') AS RecordClassName, `File`.PopupWidth, `File`.PopupHeight, `File`.Embed, `File`.LimitDimensions FROM `File` WHERE (ParentID = 33) AND (`File`.ClassName IN ('Image','GalleryPage_Image','Image_Cached')) ORDER BY `File`.`Sort` ASC LIMIT ,30 | You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '30' at line 1
At line 431 in /Users/LabBrain/Sites/JR/sapphire/core/model/Database.php

Also, I tried creating a new album but no matter what I do it just hangs when I click on save.

Thanks,
Josh

Avatar
UncleCheese

17 December 2008 at 3:27am 4085 Posts

Doh! Sorry about that, Joshuar... the line should read:

if(!isset($_REQUEST['start']) && !is_numeric($_REQUEST['start']))

Avatar
Carbon Crayon

17 December 2008 at 4:05am (Last edited: 17 December 2008 4:10am), Community Member, 598 Posts

hey UncleCheese

Been using your extension for a while now and it's really great! One thing I have been trying to add is an image count on the album list page, so that it would read "Album 1 (10 images)" etc. Having messed around I can't seem to figure out how to do it, any ideas?

Also I seem to have a strange bug whereby when I click "view all" in the Gallery management, I get the gallery paginated to 1 image per page....essentially the opposite of what it should be. Again having looked at the code I can't seem to figure out whats going wrong....

Any help is much appreciated :)

Avatar
Joshuarr

17 December 2008 at 7:10am Community Member, 37 Posts

OK, Still hanging on save album (from the popup on the album page).

Save and publish succeeded, but now on the front, clicking on an album I still get:

Notice: Undefined index: start in /Users/LabBrain/Sites/JR/gallery/code/GalleryPage.php on line 381

Trying to add a picture produces:

Notice: Trying to get property of non-object in /Users/LabBrain/Sites/JR/image_gallery/code/ImageGalleryPage.php on line 570

And trying to view an album with supposed images in it gives me:

Notice: Undefined index: start in /Users/LabBrain/Sites/JR/gallery/code/GalleryPage.php on line 381

Notice: Trying to get property of non-object in /Users/LabBrain/Sites/JR/image_gallery/code/ImageGalleryPage.php on line 207...

Grr!

Avatar
UncleCheese

18 December 2008 at 3:38am 4085 Posts

Hi, Guys,

Sorry to drop off the map for a while. I've been in this code quite a bit lately, and I think it's safe to say that it has (or will have) some major problems with the 2.3 release. 2.2.3 seems to be buggy, too. I'm working on getting something out soon. Thanks for your patience!

Here are some quick fixes for both of you:

@Joshuar, the Gallery module is riddled with these kinds of errors, and I'm hoping in the official SS release of the next version, they'll clean it up. Just change the line in GalleryPage.php to:

if(!isset($_REQUEST['start']) || ! is_numeric( $_REQUEST['start'] ) )

@Aram, great idea on the image count. Can't believe I didn't think of it. For now, try this in the ImageGalleryAlbum class:

function ImageCount() {
$images = DataObject::get("File","AlbumID = {$this->ID}");
return $images ? $images->Count() : false;
}

and on your template, just add $ImageCount to the <% control Albums %>

I'm hoping I get a chance to really get into this today. Thanks for your support!

Avatar
Joshuarr

18 December 2008 at 7:23am Community Member, 37 Posts

Thanks UncleCheese!

We're getting really close.

Things mostly work at this point (but I'm not done testing). The only error I've found so far occurs when uploading an image from the gallery page on the front end. After the add a caption page, on the final save this notice flashes then goes away:

Notice: Undefined index: uploaded_files in /Users/LabBrain/Sites/JR/image_gallery/code/ImageGalleryPage.php on line 557

Redirecting to /gallery/album/gallery... (output started on /Users/LabBrain/Sites/JR/image_gallery/code/ImageGalleryPage.php, line 557)

Avatar
Joshuarr

18 December 2008 at 7:37am Community Member, 37 Posts

Uh oh.

Making a new album is still freaking. I think the problem is in making a new folder for the new album. It was hanging if I selected 'new folder', so I turned my php setting down to only display errors. Now it moves on to allow Attach Image, but the "new folder" is Default-Album. I tried manually creating a new folder for the album, but it isn't recognized.

I'm going to try again on a clean install of ss - maybe this is db flotsam at work.

j

Avatar
Joshuarr

18 December 2008 at 8:50am Community Member, 37 Posts

This is more of a feature request - on the one album that I've been able to get working (somwhat) I noticed that the prev & next links from within the lightbox popup don't span the complete album if you have more than one page of thumb - each page you have to exit and re-click. Would there be any way to make the lightbox continuous throughout the entire album?