Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

Archive

Our old forums are still available as a read-only archive.

Moderators: martimiz, Sean, biapar, Willr, Ingo, simon_w

Moving HasManyComplexTableField::setAddTitile to TableListField?


Reply

3 Posts   1382 Views

Avatar
pjakubow

2 March 2008 at 3:10pm Community Member, 2 Posts

Hi.
First, let me thank the Team for the great job they're doing with SilverStripe. It's one of the most beautiful pieces of code I've seen among content management systems so far.

I've been playing with it just for two days, so maybe I'm missing something, but I'm wondering why $addTitle and setAddTitile() are only in HasManyComplexTableField? As $addTitle is added to the Title() called from TableListField, why not move them both to this parent?

Avatar
Ingo

11 March 2008 at 9:55pm Forum Moderator, 801 Posts

i think the naming Title() is a bit too ambiguous - strangely enough the $Title accessor is used in ComplexTableField.ss. we've already got a way to figure out the human-readable name of a class, by DataObject::$singular_name and DataObject::$plural_name. so we'd probably remove the $addTitle stuff altogether... see http://open.silverstripe.com/ticket/2312

Avatar
pjakubow

14 March 2008 at 11:39pm Community Member, 2 Posts

Yup, that's definitely cleaner. Thanks for reply.