Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

Archive

Our old forums are still available as a read-only archive.

Moderators: martimiz, Sean, biapar, Willr, Ingo, simon_w

Two bugs in photos part.


Reply

3 Posts   2330 Views

Avatar
mateusz.ujma

10 April 2007 at 12:10pm Google Summer of Code Hacker, 6 Posts

1.

Class GD located in sapphire/filesystem/GD.php

static function color_web2gd($image, $webColor) {
   if(substr($webColor,0,1) == "#") $webColor = substr($webColor,1);
      $r = hexdec(substr($webColor,0,2));
      $g = hexdec(substr($webColor,2,2));
      $b = hexdec(substr($webColor,2,2));
      
      return imagecolorallocate($image, $r, $g, $b);
   }

$g is the same as $b should be $b = hexdec(substr($webColor,4,2));

2.

If image gets corrupted during upload process i.e. network problems, resizing function will throw Fatal Error or cause a segmentation fault.

Avatar
Andy

11 April 2007 at 11:33am 230 Posts

Good spotting on number 1, it will fixed for 2.0.1. Thanks!

I'll have a look into number 2..

Avatar
Sigurd

11 April 2007 at 7:40pm Forum Moderator, 628 Posts

Cheers Mateusz; again, like Elijah, its great to see you Google Summer of Coders scanning through code and providing patches, which, as Andy suggests, are now available for download :) This supports how you've been ranked for Google to approve for tomorrow's judgement day :)