Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

Archive /

Our old forums are still available as a read-only archive.

Moderators: martimiz, Sean, biapar, Willr, Ingo, simon_w

Patch: Add needed issets to sapphire


Reply


4 Posts   1889 Views

Avatar
elijahlofgren

Google Summer of Code Hacker, 222 Posts

1 June 2007 at 11:29am

I fixed a bunch of undefined index errors in sapphire by making the following changes:
http://www.elijahlofgren.com/silverstripe/patches/Add-needed-issets-to-sapphire-trunk-revision-36318.patch

Hope this helps,

Elijah Lofgren

Avatar
Andy

230 Posts

11 June 2007 at 10:20am

Applied, cheers.

Avatar
elijahlofgren

Google Summer of Code Hacker, 222 Posts

26 June 2007 at 5:55am

This patch caused a SQL error when adding members.

I've posted the fix here: http://www.silverstripe.com/bugs/flat/1675?showPost=1744#post1744

I'll try to create a patch against the daily builds if they still contain the problem after I eat lunch.

Sorry about that,

Elijah

Avatar
elijahlofgren

Google Summer of Code Hacker, 222 Posts

26 June 2007 at 7:21am

Looks like silverstripe.2.0.DailyBuild.2007-06-25 does not contain the isset on this line:
      if($collatedGroups) {
so it does not contain the SQL bug I caused.

Thanks to Markus who fixed this in the gsoc branch.

So no patch needed,

Elijah