Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

Archive

Our old forums are still available as a read-only archive.

Moderators: martimiz, Sean, biapar, Willr, Ingo, simon_w

tinymce autosave confirmation


Reply

12 Posts   5211 Views

Avatar
elijahlofgren

14 June 2007 at 5:46am Google Summer of Code Hacker, 222 Posts

> "To be honest, this combined with Ingo's gripes about load time makes me wonder if we shouldn't just to it the same way as Google Docs - an ok/cancel box that says "do you really want to leave without saving your changes?" and if they don't, forces people to press cancel and then save manually. "

I think this is a really good idea. I plan on emailing Sean and asking him about changing the save reminder dialog to be very similar to the Google Docs one.

>I agree with Ingo that opt-out is the only acceptable solution here

I won't plan on changing the current method of "registering" fields for auto-save detection. I'll just work on improving the usability of the save reminder dialog by making it appear in all the places is should and making it faster (if Sean gives the go ahead).

Avatar
elijahlofgren

14 June 2007 at 1:51pm Google Summer of Code Hacker, 222 Posts

Sam, Ingo, and Sean all agree that using a dialog similar to the Google Docs one is good, so I'll plan on changing the Save reminder to be like that one. :)

Avatar
elijahlofgren

15 June 2007 at 8:33am (Last edited: 15 June 2007 9:08am), Google Summer of Code Hacker, 222 Posts

I've changed the alert to a javascript confirm dialog in the latest SVN of the cms gsoc branch. It seems to work in all sections.

However, in the security section only the "Group name" field has change detection.

If a new member "Firstname", "Surname", or "Email" is typed into the blanks without the "Add" button being pushed, no alert about unsaved changes is shown if another link is clicked.

Two questions:
1. Should there be change detection on the 3 "Firstname", "Surname", or "Email" blanks at the bottom of the member list?
2. If so, any tips on how to implement it?

Edit: The add recipients form (shown when "Mailing List" is clicked in Newsletter section), which is very similar to the add member form does have change detection, so I'm guessing we should find a way to implement this to maintain consistency?

Thanks,

Elijah

Avatar
elijahlofgren

16 June 2007 at 3:34pm Google Summer of Code Hacker, 222 Posts

I figured out how to enable change detection for "Firstname", "Surname", or "Email" fields. I simply had do remove them from the changeDetection_fieldsToIgnore list which I did with this patch:
http://www.elijahlofgren.com/silverstripe/patches/Fix-Usability-Issue-91-warning-needs-to-be-added-for-unsaved-changes-in-security-section-cms-gsoc-r36933.patch

Let me know if I should make any more changes, I'm marking this issue as complete: http://www.elijahlofgren.com/silverstripe/warning-needs-to-be-added-for-unsaved-changes-in-security-section/

Have a great weekend,

Elijah Lofgren