Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

Archive /

Our old forums are still available as a read-only archive.

Moderators: martimiz, Sean, biapar, Willr, Ingo, simon_w

Tree control tweaks


Go to End
Reply


15 Posts   6453 Views

Avatar
Sigurd

Forum Moderator, 628 Posts

22 June 2007 at 6:26pm

So, Elijah, is this committed to SVN now ya mean?

Avatar
Sigurd

Forum Moderator, 628 Posts

22 June 2007 at 6:26pm

So, Elijah, is this committed to SVN now ya mean?

Avatar
elijahlofgren

Google Summer of Code Hacker, 222 Posts

23 June 2007 at 1:41am

> So, Elijah, is this committed to SVN now ya mean?
Yes. :)

Here's my commit message to the gsoc branch of jsparty:
------------------------------------------------------------------------
r37261 | elofgren | 2007-06-21 21:19:00 -0500 (Thu, 21 Jun 2007) | 8 lines

Merge Site Tree Tweaks from Steve (excluding minor formatting changes). Changes:
1. Optimizations: a) Don't process a node if already done. b) Don't "Find last div before first ul"
2. New treeCloseAll() and treeOpenAll() functions.
3. Code documentation improvements.
SKIPPED: Merging code for: "Check for head/meta name='render-spans'. If present, don't call (slow) initTrees". Reason: initTree() no longer exists and I can't find a function that matches it
close enough to merge this code.
More info: http://www.silverstripe.com/contributions/flat/1611

------------------------------------------------------------------------

Avatar
Andy

230 Posts

27 June 2007 at 12:25pm

Looks good, merged into main branch. Thanks to both of you. :)

Avatar
bbodien

2 Posts

12 July 2007 at 1:42am

Hi guys,

Is the GSoC branch available anywhere? I'd really like to test out the modified tree.js, as I'm having some performance issues with largeish structures, particularly in IE6.

Thanks!

Avatar
elijahlofgren

Google Summer of Code Hacker, 222 Posts

13 July 2007 at 8:49am

> Is the GSoC branch available anywhere? I'd really like to test out the modified tree.js, as I'm having some performance issues with largeish structures, particularly in IE6.

Hi bbodien,

The GSoC branch is currently not publicly available (coming soon hopefully).

Here are two different versions of Steve's Tree control tweaks patches (in case you'd like to see the changes):
[url=http://www.elijahlofgren.com/silverstripe/patches/by-others/Steves-Site-Tree-Tweaks-fixed-whitespace.diff]Steves-Site-Tree-Tweaks-fixed-whitespace.diff[/url]
[url=http://www.elijahlofgren.com/silverstripe/patches/by-others/Steves-Site-Tree-Tweaks-in-universal-format.diff]Steves-Site-Tree-Tweaks-in-universal-format.diff[/url]

Here is the [url=http://www.silverstripe.com/tree-control/]original tree control[/url] file: [url=http://www.elijahlofgren.com/silverstripe/patches/by-others/tree-original.js]tree-original.js[/url]
And here is the version of it with the above changes applied: [url=http://www.elijahlofgren.com/silverstripe/patches/by-others/tree-patched.js]tree-patched.js[/url]

However, the tree.js used in the gsoc branch is very different from the one available at [url]http://www.silverstripe.com/tree-control/[/url] so only these changes were applied: [url=http://www.elijahlofgren.com/silverstripe/patches/by-others/Site-Tree-Tweaks-gsoc-r37261.patch]Site-Tree-Tweaks-gsoc-r37261.patch[/url]
I'm guessing that the current gsoc version might be too different to use, but here it is in case it is useful: [url=http://www.elijahlofgren.com/silverstripe/patches/by-others/tree-gsoc-r37735.js]tree-gsoc-r37735.js[/url]

Hope this helps,

Elijah Lofgren

Avatar
bbodien

2 Posts

13 July 2007 at 9:27pm

Elijah,

Many thanks for the patched versions. I'll try them out as soon as I can. Best of luck with the GSoC project, I've just been reading about it with interest on the silverstripe rss feed.

Ben

Go to Top