Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

Archive

Our old forums are still available as a read-only archive.

Moderators: martimiz, Sean, biapar, Willr, Ingo, simon_w

branches/2.0 merged into branches/gsoc


Reply

13 Posts   2407 Views

Avatar
Sam

10 July 2007 at 8:50am Administrator, 685 Posts

"Why not just make a file _manifest_exclude which can also be a zero-byte file. There is no need for a specific file format since the file itself doesn't contains any information."

I think we're in agreement. Markus, can you please add support for _manifest_exclude files and revert my XML.php filename change when it's convenient.

Avatar
Markus

10 July 2007 at 8:59pm Google Summer of Code Hacker, 152 Posts

Perfect, I created a [url=http://support.silverstripe.com/gsoc/ticket/36]ticket[/url] for that...

Avatar
Markus

11 July 2007 at 10:07pm (Last edited: 11 July 2007 10:28pm), Google Summer of Code Hacker, 152 Posts

... and implemented it :-)

The change of the manifest builder is in r38451 (added also some docBlocks, so please review the changes).

Sam's changes to the OpenID library are reverted in r38452, so it is now again in it's original version and it's easy to update it.

Avatar
Markus

12 July 2007 at 2:54am Google Summer of Code Hacker, 152 Posts

@Sam:

There was a serious bug in Object::addStaticVars() which I fixed in r38453.

If DataObject::add_extension() was used more than once per class, previously the extensions were overwritten and so only the last one was usable.

Avatar
Sam

14 July 2007 at 4:00pm Administrator, 685 Posts

Thanks for that, Markus!