Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

Archive /

Our old forums are still available as a read-only archive.

Moderators: martimiz, Sean, biapar, Willr, Ingo, simon_w

Mapping/Forum to go on demo soon


Go to End
Reply


15 Posts   3036 Views

Avatar
Sigurd

Forum Moderator, 628 Posts

12 July 2007 at 11:35am

FYI everyone, Hayden, Matt and Ofir are working on getting Ofir's Google Map demo going on demo.silverstripe.com, so there will be a little reshuffle of code on the forum and maps modules... :)

The maps module will also hit the dailybuilds shortly...

Avatar
Sigurd

Forum Moderator, 628 Posts

13 July 2007 at 4:34pm

Edited: 13/07/2007 4:36pm

Ok hit a roadblock as I'm not happy with releasing the demo when
a) the login form doesn't look good
b) the flickr gallery $Content text is wrong

- Ofir you need to fix the css / only include the CSS on proper map pages, as per http://www.silverstripe.com/google-summer-of-code-forum/flat/2401
Commit this to maps/trunk SVN.

- Lakshan you need to fix your typography issue with Matt. I suggest just using Page.ss and appending your flickrgallery to $Content by doing. THis means you don't need to worry if Page.ss changes...

class ForumMemberMapPage_Controller extends Page_Controller {
   function Content() {
      if(ClassInfo::exists('Forum')) {         
         $map = new GMap('ForumMembers', DataObject::get('MemberLocation'), new GMapPoint(33.750298 ,7.412841), 1);
         return $this->Content.$map->displayForumMembers();
      }
      else {
         return $this->Content.'You need the forum module installed to use this page type';
      }
}
}

Avatar
laktek

Google Summer of Code Hacker, 76 Posts

16 July 2007 at 12:30am

Sig : Made the changes as you suggested. Please check and see is it alright

BTW, Sorry for being late on this had few assignments and exams in the uni last week.

Avatar
Sigurd

Forum Moderator, 628 Posts

16 July 2007 at 9:21am

Edited: 16/07/2007 9:21am

That's cool. Two comments then we can release mashups0.11 and put it up at demo.silverstripe.com

a) We need padding around the images.
b) I removed mashups/templates/Layout/FlickrGallery.ss. Sorry I realise it probably wasn't clear but the idea behind appending to $Content meant you didn't need to have a Layout file, which for the current state of SilverStripe, means its easier for it to work with any random website in the world. For instance, if someone goes and plays significantly with mysite/Layout/Page.ss then you don't need to update the FlickrGallery.ss
c) I just want to confirm you've fixed the XML error that people raised a few days ago?

See attached image. Once you've fixed the CSS (ensure it works with SilverStripe 202b on IE6, IE7, Safari, FireFox)...

Avatar
Sigurd

Forum Moderator, 628 Posts

16 July 2007 at 9:22am

(oops, didn't upload file)

Avatar
laktek

Google Summer of Code Hacker, 76 Posts

16 July 2007 at 10:16am

Sig:
a) Added padding around images.
b) Idea was clear. FlickrGallery.ss is removed.
c) I tested with titles having " " and ' ' characters and no XML error was raised.

Avatar
Sigurd

Forum Moderator, 628 Posts

16 July 2007 at 10:29am

Edited: 16/07/2007 10:32am

Seems to work well. Matt, can you update

ReadMe, add a changelog to SVN.
a) fixed XML error
b) return gallery inside $Content
c) cosmetic improvements

re-tag this in SVN (0.11),
make .tar.gz

upload to silverstripe.com/assets/downloads/modules/
relink in the modules-download and google-summer-of-code-fruit-1-flickrgallery/ pages

Avatar
Sigurd

Forum Moderator, 628 Posts

16 July 2007 at 10:37am

Ofir, so we just wait on you to fix up the stuff as mentioned above, and the forum, flickr, and maps stuff will be published to http://demo.silverstripe.com ...

Go to Top