Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

Archive

Our old forums are still available as a read-only archive.

Moderators: martimiz, Sean, biapar, Willr, Ingo, simon_w

Change Detection Broken in TinyMCE 2.1.1.1 cause Confirm dialogue every time page is edited


Reply

1042 Views

Avatar
elijahlofgren

18 July 2007 at 2:12pm (Last edited: 18 July 2007 2:14pm), Google Summer of Code Hacker, 222 Posts

As of r38891 in the gsoc branch, any change to a HtmlEditor field will cause a confirm dialogue to show whenever new selection is made in the left tree even if the "Save" button has been clicked.

This bug was caused by r38620 which merged in TinyMCE 2.1.1.1 because after doing the following, the bug disappears:

svn up cms --revision 38619 && svn up jsparty/ --revision 38619 && svn up sapphire/ --revision 38619

My dev enviroment is as follows:
Apache/2.2.3 (Ubuntu) PHP/5.2.1
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.4) Gecko/20061201 Firefox/2.0.0.4 (Ubuntu-feisty)

Here is a hack that works around this problem: [url=http://www.elijahlofgren.com/silverstripe/diffs/Hack-To-Fix-TinyMCE-Change-Detection-cms-gsoc-r38861.diff]Hack-To-Fix-TinyMCE-Change-Detection-cms-gsoc-r38861.diff[/url]

Here is a gsoc trac ticket I filed about this [url=http://support.silverstripe.com/gsoc/ticket/50]Save reminder still shows after a page or newsletter draft is saved and a new selection is made in the left tree[/url]

I tried for quite a while, but was unable to fix this bug properly. Hopefully the above hack will help whoever works on this. ;)