Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

Archive

Our old forums are still available as a read-only archive.

Moderators: martimiz, Sean, biapar, Willr, Ingo, simon_w

Bug in TinyMCE2


Go to End
Reply

9 Posts   4513 Views

Avatar
Markus

8 August 2007 at 3:48am (Last edited: 8 August 2007 3:59am), Google Summer of Code Hacker, 152 Posts

There is a bug in TinyMCE which makes it unusable for IE. I attached a patch since I have not the rights to commit to the TinyMCE code... I also [url=http://sourceforge.net/tracker/index.php?func=detail&atid=635684&aid=1769487&group_id=103281]filed the issue at their Sourceforge tracker[/url]

Patch:

Index: tiny_mce_src.js
===================================================================
--- tiny_mce_src.js   (revision 39628)
+++ tiny_mce_src.js   (working copy)
@@ -1571,7 +1571,7 @@
         return;
      }

-      if (tinyMCE.isRealIE && window.event.type == "readystatechange" && document.readyState != "complete")
+      if (tinyMCE.isRealIE && window.event && window.event.type == "readystatechange" && document.readyState != "complete")
         return true;

      if (tinyMCE.isLoaded)

Avatar
Markus

9 August 2007 at 3:00am Google Summer of Code Hacker, 152 Posts

Thanks for patching it Andy.

Avatar
elijahlofgren

9 August 2007 at 9:05am Google Summer of Code Hacker, 222 Posts

Thanks Markus!

You fixed this bug for me: [url=http://support.silverstripe.com/gsoc/ticket/63]Ticket #63 - Checkboxes on Mailing List Bounced tab don't work & X delete links reloads whole page in IE6 or IE7[/url] :)

I think you also fixed this bug: [url=http://open.silverstripe.com/ticket/1370]Ticket #1370 - Behaviour is not applied with ajax in IE[/url]

Thanks again,

Elijah

Avatar
Markus

10 August 2007 at 3:47am (Last edited: 10 August 2007 3:48am), Google Summer of Code Hacker, 152 Posts

No problem :-) I didn't look at those tickets but yes, it should fix both issues.

There is another javascript bug (at least in IE7):
The confirmation dialog ("Are you sure you want to navigate away from this page...") appears also if no changes where made.

There was somewhere a discussion about that but I can't find it.. have you an idea where the bug resides Elijah? Otherwise I'll open a ticket for it.

Avatar
elijahlofgren

10 August 2007 at 7:15am Google Summer of Code Hacker, 222 Posts

> There is another javascript bug (at least in IE7):
The confirmation dialog ("Are you sure you want to navigate away from this page...") appears also if no changes where made.
> There was somewhere a discussion about that but I can't find it.. have you an idea where the bug resides Elijah? Otherwise I'll open a ticket for it.

I think this is the bug you are looking for: [url=http://open.silverstripe.com/ticket/1372] Ticket #1372 - Change Detection Broken in TinyMCE 2.1.1.1 cause Confirm dialogue every time page is edited[/url] :)

Avatar
Markus

10 August 2007 at 7:55am Google Summer of Code Hacker, 152 Posts

Right.. I'm talking about that bug.. are you already working on it Elijah?
At the moment I'm busy but I could help you by the end of next week..

Avatar
elijahlofgren

10 August 2007 at 8:00am Google Summer of Code Hacker, 222 Posts

> Right.. I'm talking about that bug.. are you already working on it Elijah?

No, I'm not. I did find a hack to work around the problem though: [url]http://open.silverstripe.com/attachment/ticket/1372/Hack-To-Fix-TinyMCE-Change-Detection-cms-gsoc-r38861.diff[/url]

> At the moment I'm busy but I could help you by the end of next week..

It'd be great if you would work on this. This bug is quite annoying, and I don't enjoy working on TinyMCE very much. ;)

Avatar
Markus

13 August 2007 at 8:33pm Google Summer of Code Hacker, 152 Posts

OK, I'll see what I can do.. I plan to work on this on Friday.. so if you find a solution or more information about this bug in the meantime tell me!

Go to Top