Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

DataObjectManager Module /

Discuss the DataObjectManager module, and the related ImageGallery module.

Moderators: martimiz, UncleCheese, Sean, biapar, Willr, Ingo, swaiba, simon_w

Maintaining DOM


Reply


4 Posts   593 Views

Avatar
micahsheets

Community Member, 165 Posts

26 July 2011 at 11:50am

Uncle Cheese,

I was wondering if you wanted to pass the maintaining of DOM to some of the community. I have seen many bugs creeping into it as SS changes (not that your code is buggy but as SS changed not everything has been completely updated yet). There are numerous posts regarding different common problems and many of us are implementing fixes on our own sites. I now have to keep my own distribution that has many of the fixes in it as the versions available via Git are no longer useable. I would be happy to do what I can to put my own fixes in as I make and test them.

One such update that should be made to trunk is in this post http://www.silverstripe.org/dataobjectmanager-module-forum/show/15732 by aleks. I have been making this change myself for a while now.

Another one is the Folder creation problems people have been having. This is the post where I submitted what is my work in progress fix that is actually working pretty good. http://www.silverstripe.org/dataobjectmanager-module-forum/show/15155#post305877

I have also noticed that FileDataObjectManager creates the Assets folder inside the existing Assets folder if the $GalleryImageManager->setUploadFolder($uploadfolder) function is used to set the upload folder instead of the dropdown. I am sure many of us would like to see our fixes implemented as we must for a time still build new websites with SS 2.4.5 while waiting for SS 3.0

Avatar
UncleCheese

Forum Moderator, 4093 Posts

27 July 2011 at 1:15am

Hi, Micah,

Usually I have people submit the changes as pull requests on Github, and I'm pretty good about merging them into the core in a timely manner.

--------------------
SilverStripe tips, tutorials, screencasts and more: http://www.leftandmain.com

Avatar
micahsheets

Community Member, 165 Posts

27 July 2011 at 4:36am

Thanks for the info Uncle Cheese. I will look into how to do a pull request. I usually don't like to use Github but I guess I best get my learn on and find out why everyone wants to use it these days. I still prefer SVN for my own development but maybe that isn't what Git is for.

Avatar
UncleCheese

Forum Moderator, 4093 Posts

28 July 2011 at 2:56pm

You won't prefer SVN once you start using Git. It's like preferring cassettes to an iPod Nano.

Because Git is a distributed version control system, it's very conducive to exactly what you're talking about. Every user gets his own clone of the entire repository, so when you make changes, you can just tell me, and I merge yours with mine. With SVN, the repository lives in only one place, so all you can do is email me a diff file, which is pretty primitive, and highly prone to human error.

Go for it!

---------------
Silverstripe tips, tutorials, screencasts, and more. http://www.leftandmain.com