Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

E-Commerce Modules /

Discuss about the various e-commerce modules available:
Ecommerce, SS Shop, SilverCart and SwipeStripe
Alternatively, have a look the shared mailinglist.

Moderators: martimiz, Nicolaas, Sean, frankmullenger, biapar, Willr, Ingo, Jedateach, swaiba, simon_w

sprintf error with nested quotes - solved in SSViewer.php


Reply


4 Posts   1270 Views

Avatar
kcd

Community Member, 54 Posts

3 April 2011 at 10:06pm

Edited: 03/04/2011 10:08pm

See http://www.silverstripe.org/dataobjectmanager-module-forum/show/9482?start=32#post293190

I found I still had this problem with the latest releases in XAMPP. Perhaps the fix should make it into the Silverstripe core?

Avatar
Willr

Forum Moderator, 5513 Posts

4 April 2011 at 9:23am

All core contributions need to be submitted to the github project as pull requests. Otherwise they'll never be found by the dev team! Plus we can review the exact changes easier.

Avatar
kcd

Community Member, 54 Posts

4 April 2011 at 10:51am

Thanks Will. I found the pull requests however I don't see how I can add one myself, am I missing something or is it restricted to the dev team?

Avatar
Willr

Forum Moderator, 5513 Posts

4 April 2011 at 12:31pm

Nope, pull requests can be contributed from anyone and is one of the reasons we went to Git / github was to allow everyone to contribute easier. Instructions are on http://doc.silverstripe.org/sapphire/en/misc/contributing#sending-pull-requests-for-git