Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

General Questions

General questions about getting started with SilverStripe that don't fit in any of the categories above.

Moderators: martimiz, Sean, biapar, Willr, Ingo, swaiba, simon_w

Requirements and HTML5 <header tag


Reply

3 Posts   1914 Views

Avatar
Wilson

25 May 2010 at 6:02am (Last edited: 25 May 2010 6:07am), Community Member, 63 Posts

Hi everyone,

I've just built my first HTML5 front-end and am bolting it on to SS2.4. I noticed that the required JS and CSS is written twice even though I have

Requirements::set_write_js_to_body(false);

in my _config.php

I have a suspicion that it's because my header is wrapped in the <header> tag.

Has anyone come across this before?

Thanks!
Wilson

Avatar
Wilson

25 May 2010 at 6:17am Community Member, 63 Posts

Looks like it 688 and 689 in Requirements.php. I'll see if this bug has been logged.

Avatar
Willr

25 May 2010 at 11:28pm Forum Moderator, 5511 Posts

Good point. I think it appends it to </head rather than </head> so </head will match both your elements. Should be a simple fix for the Requirements class to use </head> rather than </head OR just use the first </head.