Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

Template Questions

bugfix: shortcodes not evaluated in RSS feeds


Reply

4 Posts   1084 Views

Avatar
MattB

29 April 2011 at 3:24am Community Member, 7 Posts

Hi team,

Shortcodes (eg the native [sitetree_link id=123]) don't appear to be evaluated inside RSS feeds, they're served as raw text.

This can be fixed in Text::AbsoluteLinks() which is called in RSSFeed.ss:
sapphire/core/model/fieldtypes/Text.php#77

by changing:
return HTTP::absoluteURLs($this->value);

to:
return HTTP::absoluteURLs($this->forTemplate());

Cheers, Matt

Avatar
Willr

30 April 2011 at 1:44am Forum Moderator, 5511 Posts

Hi,

Please submit bugfixes, patches as pull requests (http://doc.silverstripe.org/sapphire/en/misc/contributing#sending-pull-requests-for-git) or simply make a ticket on open.silverstripe.org and the core devs can make sure it gets into the release / look into the issue.

Cheers,

Avatar
MattB

30 April 2011 at 2:49am Community Member, 7 Posts

Willr,

Unfortunately I'm locked out of TRAC and the "forgot my password" feature doesn't work.

Thanks

Avatar
Willr

30 April 2011 at 3:51pm Forum Moderator, 5511 Posts

If you could send me an email (will@silverstripe.com) from the registered account email you signed up with I'll reset your password in the backend (simply a security measure!).

For patches it's more important to get the pull request submitted than a trac ticket.

Is this functionality not covered by unit tests? For core patches we're trying to get as much covered as possible (plus it's good practise) so if you could knock up a quick test, check that it fails without your patch and that it passes post patch (without breaking anything else) it will make the process of pulling your changes much quicker.

Thanks for raising this!