Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

We've moved the forum!

Please use forum.silverstripe.org for any new questions (announcement).
The forum archive will stick around, but will be read only.

You can also use our Slack channel or StackOverflow to ask for help.
Check out our community overview for more options to contribute.

Upgrading SilverStripe /

Ask questions about upgrading SilverStripe to the latest version.

Moderators: martimiz, Sean, Ed, biapar, Willr, Ingo, swaiba

From 2.3.1 to 2.3.2 error on URLSegment


Go to End


5 Posts   1942 Views

Avatar
biapar

Forum Moderator, 435 Posts

24 June 2009 at 1:31am

After Upgrade from 2.3.1 to 2.3.2 I've error caused by this function in page.php of mysite:

function GetLinkFromID($id = 1) {
$do = DataObject::get_one('Page', '`SiteTree_Live`.ID = '.$id, true);
return ($do->URLSegment); <-- here

Error:
[Notice] Trying to get property of non-object

Avatar
Hamish

Community Member, 712 Posts

24 June 2009 at 9:01am

Are you sure the upgrade caused it?

The error means that there is no page record with the id. You should make the function safer by changing it to:

function GetLinkFromID($id = 1) { 
	$do = DataObject::get_one('Page', '`SiteTree_Live`.ID = '.$id, true); 
	return $do ? $do->URLSegment : false;

This way, if there is not page with that id, it will return false instead of trying to access a member of the nonexistent object.

Avatar
biapar

Forum Moderator, 435 Posts

24 June 2009 at 8:55pm

I've update SS production installation and there is page with ID = 1.
Before updating, it work.

Best Regards

Avatar
Hamish

Community Member, 712 Posts

25 June 2009 at 9:20am

Well this: "'`SiteTree_Live`.ID = '.$id" is not returning anything.

Maybe the field SiteTree_Live changed?

Avatar
ajshort

Community Member, 244 Posts

25 June 2009 at 9:22am

You shouldn't be querying form the Live table - instead you should just do "`SiteTree`.`ID` = $ID" and your query will automatically be rewritten if you are getting data from the Live table.