Hello,
I've a problem with the function Requirements::combine_files. The function doesn't generate the files, in the example the files should be called "cssmin.css" and "jsmin.js".

Maybe I have a mistake in my source code. But I can't find it. I hope you can help me with this problem.

$theme = SSViewer::current_theme();
      echo $path = 'themes/'.$theme.'/';
      
Requirements::combine_files(
   $path.'css/cssmin.css',
   array(
      $path.'css/layout.css',
      $path.'css/typography.css',
      $path.'css/form.css',
      $path.'css/print.css',
      $path.'css/highslide.css',
   )
      );
      
Requirements::combine_files(
   $path.'js/jsmin.js',
   array(
'jsparty/prototype.js',
            'jsparty/behaviour.js',
            'jsparty/prototype_improvements.js',
            'sapphire/javascript/i18n.js',
            'sapphire/javascript/Validator.js',
      $path.'js/highslide.js',
      $path.'js/stars.js',
   )
      );      

Hi

I guess there's a bug within the Requirements::process_combined_files() method. I was not able getting this running without adjusting the code a little. The problem is that during processing of the combined files no file of the combined array will be added to the central javascript or css-holder array why no file is set for rendering on the page.

Here is my working example:

1. Add the following code to sapphire/core/ Requirements.php -> class Requirements_Backend -> function process_combined_files() [line ~790]

2. Use this code within your Page.php

Please also make sure that you are not in "dev" mode, cause this feature will only work in "live" mode.

Best regards, Bjoern

Thank you for your help. I will try this solution in the next days.

Today I wrote a solution, which you don't have to adjusting the sapphire source code. Furthermore only the combined files will implement into the theme, so there are no double files.
Many thanks to ajshort! You had the right approach to the problem!

And here is the source code to use combined_files: (Director::set_environment_type("live")

public function init() {
      parent::init();

       // set the path of the files
         $theme = SSViewer::current_theme();
         $path = 'themes/'.$theme.'/';

         //Register the file extension
         Requirements::css($path.'css/layout.css');
         Requirements::css($path.'css/typography.css');
         Requirements::css($path.'css/form.css');
         Requirements::javascript('sapphire/javascript/i18n.js');
         Requirements::javascript('sapphire/javascript/Validator.js');
         Requirements::javascript('jsparty/behaviour.js');
         Requirements::javascript('jsparty/prototype.js');
         Requirements::javascript('jsparty/prototype_improvements.js');

         /*
         Start the process of combine_files. The combined files will
         included automatically in our theme. Because of this you don't
         have to write <% require ... %>
         */

         Requirements::combine_files (
       $path.'css/cssmin.css',
       array(
       $path.'css/layout.css',
         $path.'css/typography.css',
         $path.'css/form.css',
         )
         );

         Requirements::combine_files (

         $path.'css/jsmin.js',
       array(
       'sapphire/javascript/i18n.js',
         'sapphire/javascript/Validator.js',
         'jsparty/prototype.js',
         'jsparty/behaviour.js',
         'jsparty/prototype_improvements.js'
               )
         );

         /*
         we doesn't need these files anymore, because they are included in
         cssmin.css and jsmin.js'. So we start the process clear()
         */
         Requirements::clear('sapphire/javascript/i18n.js');
         Requirements::clear('sapphire/javascript/Validator.js');
         Requirements::clear('jsparty/behaviour.js');
         Requirements::clear('jsparty/prototype.js');
         Requirements::clear('jsparty/prototype_improvements.js');
         Requirements::clear($path.'css/layout.css');
         Requirements::clear($path.'css/typography.css');

   }