Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

We've moved the forum!

Please use forum.silverstripe.org for any new questions (announcement).
The forum archive will stick around, but will be read only.

You can also use our Slack channel or StackOverflow to ask for help.
Check out our community overview for more options to contribute.

DataObjectManager Module /

Discuss the DataObjectManager module, and the related ImageGallery module.

Moderators: martimiz, UncleCheese, Sean, Ed, biapar, Willr, Ingo, swaiba

OMG NEW STUFF!


Go to End


28 Posts   3928 Views

Avatar
UncleCheese

Forum Moderator, 4102 Posts

2 February 2010 at 3:08am

Great. Could you please just paste the last 10 lines or so of RelationDataObjectManager.ss the way it is supposed to be? Every time I look at that template, I see the correct number of closing divs.

Also, paste in FileRelationDataObjectManager if necessary.

Avatar
bummzack

Community Member, 904 Posts

2 February 2010 at 4:06am

Edited: 02/02/2010 4:08am

Hi UC

FileRelationDOM seems to be fine.
Here are the last lines of the file, red is what I added to fix the issue:

			  <% end_if %>				
				<div class="per-page-control">
					<% if ShowAll %><% else %>$PerPageDropdown<% end_if %>
				</div>
			</div>
		</div>
	</div>
	</div>
	$ExtraData	
</div>

Something seems to be wrong with indentation... if you count the opening divs, you'll notice that there's one too much.

+1 = 1	<div class="bottom-controls">
+1 = 2		<div class="rounded_table_bottom_right">
+1 = 3			<div class="rounded_table_bottom_left">
+1 = 4			  <div class="checkboxes">
					<% if Sortable %>
+1 = 5    				<div class="sort-control">
    						<input id="showall-{$id}" type="checkbox" <% if ShowAll %>checked="checked"<% end_if %> value="<% if Paginated %>$ShowAllLink<% else %>$PaginatedLink<% end_if %>" /><label for="showall-{$id}"><% _t('DataObjectManager.DRAGDROP','Allow drag &amp; drop reordering') %></label>
-1 = 4    				</div>
					<% end_if %>
			  <% if RelationType = ManyMany %>
  			  <% if Can(only_related) %>
+1 = 5  			    <div class="only-related-control">
  					   <input id="only-related-{$id}" type="checkbox" <% if OnlyRelated %>checked="checked"<% end_if %> value="<% if OnlyRelated %>$AllRecordsLink<% else %>$OnlyRelatedLink<% end_if %>" /><label for="only-related-{$id}"><% _t('DataObjectManager.ONLYRELATED','Show only related records') %></label>
-1 = 4            </div>
          <% end_if %>
			  <% end_if %>				
+1 = 5				<div class="per-page-control">
					<% if ShowAll %><% else %>$PerPageDropdown<% end_if %>
-1 = 4				</div>
-1 = 3			</div>
-1 = 2		</div>
-1 = 1	</div>
Here's one missing
	$ExtraData	
This one is coming from the beginning of the file ---></div>

Update: Ugh.. the above is really messy.. sorry. I hope you see where the problem is nevertheless ;)

Avatar
mattclegg

Community Member, 56 Posts

2 February 2010 at 10:31pm

I cant see a fix to stop the submit button having a really long name in r356 -has this been done?

& if Image is the last field, the 'Attach Image' button disappears behind the gradient in firefox on a mac. Iv done a screenshot for this, its probably just a css issue. Shall I work out the fix?

http://urcms.net/overlap-screenshot.png

Avatar
UncleCheese

Forum Moderator, 4102 Posts

3 February 2010 at 5:12am

Yeah, I just checked in that fix. It may be different than the one you implemented, so be sure to reconcile your changes when you update.

Go to Top