DataObjectManager Module

SilverStripe Forums » DataObjectManager Module » Bug Reports

Discuss the DataObjectManager module, and the related ImageGallery module.

Moderators: martimiz, UncleCheese, Howard, Sean, Ryan M., biapar, Willr, Ingo, swaiba, simon_w

Page: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38	Go to End	Next >
Author	Topic:	37773 Views

MarijnKampf

Community Member
150 Posts

Re: Bug Reports

25 November 2010 at 7:58pm

I can see how the SilverStripe DB/file implementation is limiting in this respect.
The thumbnails are completely independent from the uploads. The issue is that setting an image to an upload breaks the thumbnail on other unrelated pages if it happens to be the same file.
Two different possible solutions (I think):
- Download is currently extended from File, could the solution be to extend Download from both File and Image?
- Is it possible to restrict the assets source folder used in Uploadify?
fabeat

Community Member
2 Posts

Re: Bug Reports

29 December 2010 at 5:39am

Hi!
I think the encoding of the german language file for the uploadify module should be UTF-8
https://gist.github.com/gists/757396/download
Cheers, Fabian
s!m

Community Member
9 Posts

Re: Bug Reports

5 January 2011 at 1:56am

I've updated the german language files for DOM, ImageGallery and Uploadify as those were not available by the time I needed those...
As I see, the now active german language files all include characters like "ä,ü,ß", etc while those should possibly be "ä, &uuml, etc..". So I rewrote those files and translated all items with "ä, etc." so that the problems with the encoding of the files are gone...
I also found one untranslatable string in DataObjectManager_holder.ss:
line 3, it says:
<p>You may add $PluralTitle once you have saved for the first time.</p>

where it should be something like this:
<p><% sprintf(_t('ADDAFTERSAVE','You may add %s once you have saved for the first time.'),$PluralTitle) %></p>

To translate this line I added the following to my "de_DE.php"-language file:
$lang['de_DE']['DataObjectManager_holder.ss']['ADDAFTERSAVE'] = 'Sie können %s hinzufügen, sobald Sie das erste Mal gespeichert haben.';

If anyone's interested, here are the links for those three language files, maybe they are useful to someone...
DOM: http://pastebin.com/iCbN1M2Q
ImageGallery: http://pastebin.com/SQuEhNv0
Uploadify: http://pastebin.com/ZfB7sjhM
Best regards,
s!m
socks

Community Member
182 Posts

Re: Bug Reports

7 January 2011 at 5:03pm Last edited: 7 January 2011 5:05pm

ImageGallery Rotate Image Not Working (SS 2.4.4, Image Gallery r525, Uploadify r524)
Hey Uncle Cheese,
I noticed the Rotate Image feature wasn't working on my Localhost. I came across this fix http://www.silverstripe.org/dataobjectmanager-module-forum/show/13308 and didn't know if you didn't think it was a viable solution or if you hadn't seen it since it wasn't in this Bug Reports thread.
Seems to work, but there's some weirdness (in the Pop-up) when you only rotate 90 deg. and the rotated thumb isn't represented properly (CMS > Content > Photos) until I log out and back in.
Thanks
Devlin

Community Member
119 Posts

Re: Bug Reports

12 February 2011 at 1:33am Last edited: 12 February 2011 2:05am

Hi there.
Traversing $summary_fields seems to not work with HasManyDataObjectManager.
$DOM = new HasManyDataObjectManager($this, 'Beleuchtung', 'ReportData_has_many_Beleuchtung');
class ReportData_has_many_Beleuchtung extends DataObject {
static $has_one = array(
'ESL' => 'ReportData_has_one_ESL'
)
static $summary_fields = array(
'ESL.Name' => 'ESL',
);
}

In HasManyDataObjectManager.php the line 72-78 in getQuery() seems to be the problem.
// Add more selected fields if they are from joined table.
$SNG = singleton($this->sourceClass);
foreach($this->FieldList() as $k => $title) {
if(! $SNG->hasField($k) && ! $SNG->hasMethod('get' . $k))
$query->select[] = $k;
}

If I delete the "!" in the if condition or completely delete these lines, traversing works like intended.
But maybe I'm missing something.
moloko_man

Community Member
72 Posts

Re: Bug Reports

12 February 2011 at 9:14am Last edited: 12 February 2011 9:16am

Maybe this is in the wrong place... When having nested DOM objects, the nested DOM window is displayed inside the first DOM window, but on different browsers it shows up in different places and in IE 7 has different desired results.
Chrome on Mac, the nested window opens below all the first window content and buttons - https://img.skitch.com/20110211-x2fj7d627gejdpjexp27urnqfs.jpg
Firefox on Mac/Windows, the nested window opens in the correct place, but there is no control to set the width - https://img.skitch.com/20110211-8wa8af2nqfua8q6ym59qbcbicd.jpg
IE7/IE8 the nested window opens OVER the first window, forcing you to close the First Window DOM after you save the nested object. A pain if you are adding more than one file to the First DOM - https://img.skitch.com/20110211-e99yac4n2jrdm2uwk1tddtup4k.jpg
I don't have IE9 to test it
Functionality is still there, so this is more of an UI/UX bug.
BLU42 Media

Community Member
71 Posts

Re: Bug Reports

25 February 2011 at 9:20am

I'm using SS 2.4.5 w/ the DatePickerField in Model Admin and noticed that the field is pre-filling with both the date and time. I adjusted the code in the Field() function to remove the time. The old CalendarDateField had this issue too. Is this something you might be willing to add to the field code?
      #$val = $this->attrValue();
      //   BLU FIX... field was returning time
      if ($this->attrValue()) {
         $val = 'dd/mm/yy' == self::$dateFormat
            ? date('d/m/Y', strtotime( $this->attrValue() ))
            : date('m/d/Y', strtotime( $this->attrValue() ));
      }
      else {
         $val = null;
      }

Thanks,
John
moloko_man

Community Member
72 Posts

Re: Bug Reports

10 March 2011 at 8:29am

Not sure if this is an Uploadify or DataObjectManager bug, but when using the ImageDataObjectManager and choosing an existing image to import, the image is not imported properly.
The info is all correct in the database, but the thumbnail is a broken image and the URLSegment is "assets/" instead of the correct full path to the image. The image also does not show up in the front end.
In order to get the image to show up I have to click on the blank thumbnail to edit the details. Inside the details there is no thumbnail and I'm presented with the standard SS image uploader instead of uploadify. I have to repeat the process of choosing an existing image from the file store and then attach it. Once I do that and hit save, the thumbnail shows up and the image shows up on the front end.
Images going through the above process:

Here is my code for the page & dataobject
HomePage.php
class HomePage extends Page {
...
static $has_many = array(
      'SliderImages' => 'SliderImage',
   );
public function getCMSFields() {
$fields = parent::getCMSFields();
$a = array('png', 'jpg', 'jpeg', 'gif');
$dom = new ImageDataObjectManager(
         $this,
         'SliderImages',
         'SliderImage'
      );
      $dom->setUploadFolder('Uploads/HomePageHeroImages');
      $dom->setAllowedFileTypes($a);
      $dom->setPageSize(20);
$fields->addFieldToTab('Root.Content.SliderImages', $dom);
   return $fields;
}
...
}
SliderImage.php
static $has_one = array(
      'Photo' => 'BetterImage',
      'HomePage' => 'HomePage',
   );

any insight on this?
I can replicate this issue on my local dev environment (OSX 10.6, MAMP PRO) and production server (Rackspace)