I am using imagedataobject like this.

class Client extends DataObject
{
   static $db = array (
      'Name' => 'Text',
      'Description' => 'Text',
      'Category' => "Enum('Direct, Agency')"
      
   );
   
   static $has_one = array (
      'Attachment' => 'Image',
      'ClientHolder' => 'ClientHolder'
   );
   
   public function getCMSFields_forPopup()
   {
      return new FieldSet(
         new TextField('Name'),
         new TextareaField('Description'),
         new DropdownField('Category','Category', singleton('Client')->dbObject('Category')->enumValues()),
         new FileIFrameField('Attachment')
      );
   }
}

all i need to know is how do i produce to the page items that have been saved as 'category=Direct', or 'Category=Agency'

at the moment I am using

<div class="client_wrapper">
<% control Attachment %>
<div class="client_main">
$CroppedImage(167,113)
</div>
<% end_control %>
</div>      
<% end_control %>

which produces all of them

thanks

The method proposed by UncleCheese contains a potential security risk. You should never trust URL parameters without checking them first. Eg. something like this:

Edit Sorry, I accidentally posted this before I finished my post. The above method is probably the most basic of all, which checks if the ID is either 'direct' or 'agency'. A pattern match would also be fine:

The advantage of the regex is, that it will match 'direct', 'Direct', 'DIRECT', etc. Make sure to normalize the value to lowercase, since otherwise you might not get any results, since the DB usually compares strings case-sensitive.

This is why it's bad to filter by string and not a true data relation. Ideally, your categories are an object associated with your Client object, and then it just beccomes /category/123

if($cat = DataObject::get_by_id("Category",$this->urlParams['ID']))
// ok
else
// bad url

Also helps to put an is_numeric check on there, too, so if some bonehead goes to /category/foo it doesn't throw a fatal error.