Jump to:

1030 Posts in 805 Topics by 311 members

Forum Module

SilverStripe Forums » Forum Module » in trunk: the new ConfirmPassword field in the registration form messes up the layouts

Discuss the Forum Module.

Moderators: martimiz, Sean, biapar, Willr, Ingo, swaiba, simon_w

Page: 1
Go to End
Author Topic: 1260 Views
  • Kalileo
    Avatar
    Community Member
    127 Posts

    in trunk: the new ConfirmPassword field in the registration form messes up the layouts Link to this post

    Hi Will,

    you recently tidied up the code in trunk to use the ConfirmPassword field. As a side effect of that my layouts had been messed up because now the registration form has nested class="middleColumn" divs.

    It does not look to me as if that was intended?

    <div id="Password" class="field confirmedpassword nolabel"><div class="middleColumn"><div id="Password[_Password]" class="field password "><label class="left" for="Password-_Password">Password</label><div class="middleColumn"><input class="text" type="password" id="Password-_Password" name="Password[_Password]" value="" /></div></div><div id="Password[_ConfirmPassword]" class="field password "><label class="left" for="Password-_ConfirmPassword">Confirm Password</label><div class="middleColumn"><input class="text" type="password" id="Password-_ConfirmPassword" name="Password[_ConfirmPassword]" value="" /></div></div></div></div>

    I think the outer 2 divs are not needed and should be taken out. But where is that generated, where to patch?

  • Willr
    Avatar
    Forum Moderator
    5490 Posts

    Re: in trunk: the new ConfirmPassword field in the registration form messes up the layouts Link to this post

    Well I'm picking this is what the ConfirmPasswordField throws out so I would need to change that core field holder. It wouldn't be a patch for the forum (unless we go back to the duplicate password fields which was the reason we hit the security issue)

  • Kalileo
    Avatar
    Community Member
    127 Posts

    Re: in trunk: the new ConfirmPassword field in the registration form messes up the layouts Link to this post

    Yeah, that was what I feared you would say.

    How about a switch in ConfirmPasswordField to set "noWrappingDiv" (if this wrapping div is really needed and uses somewhere, however i wouldn't be surprised if it is not needed anywhere and can be taken off completely).

    For now the only option I see is to try to workaround it by throwing some more CSS rules at it. Or you change ConfirmPasswordField ;)

  • Willr
    Avatar
    Forum Moderator
    5490 Posts

    Re: in trunk: the new ConfirmPassword field in the registration form messes up the layouts Link to this post

    Well rather than breaking all the sites which use the confirmed password field styles perhaps it might be easier if you update your css

    1260 Views
Page: 1
Go to Top

Want to know more about the company that brought you SilverStripe? Then check out SilverStripe.com

Comments on this website? Please give feedback.