Jump to:

22983 Posts in 11709 Topics by 2827 members

General Questions

SilverStripe Forums » General Questions » Requirements and HTML5 <header tag

General questions about getting started with SilverStripe that don't fit in any of the categories above.

Moderators: martimiz, Sean, biapar, Willr, Ingo, swaiba, simon_w

Page: 1
Go to End
Author Topic: 1849 Views
  • Wilson
    Avatar
    Community Member
    63 Posts

    Requirements and HTML5 <header tag Link to this post

    Hi everyone,

    I've just built my first HTML5 front-end and am bolting it on to SS2.4. I noticed that the required JS and CSS is written twice even though I have

    Requirements::set_write_js_to_body(false);

    in my _config.php

    I have a suspicion that it's because my header is wrapped in the <header> tag.

    Has anyone come across this before?

    Thanks!
    Wilson

  • Wilson
    Avatar
    Community Member
    63 Posts

    Re: Requirements and HTML5 <header tag Link to this post

    Looks like it 688 and 689 in Requirements.php. I'll see if this bug has been logged.

  • Willr
    Avatar
    Forum Moderator
    5462 Posts

    Re: Requirements and HTML5 <header tag Link to this post

    Good point. I think it appends it to </head rather than </head> so </head will match both your elements. Should be a simple fix for the Requirements class to use </head> rather than </head OR just use the first </head.

    1849 Views
Page: 1
Go to Top

Want to know more about the company that brought you SilverStripe? Then check out SilverStripe.com

Comments on this website? Please give feedback.