Jump to:

23376 Posts in 18295 Topics by 2867 members

General Questions

SilverStripe Forums » General Questions » How do I submit patches

General questions about getting started with SilverStripe that don't fit in any of the categories above.

Moderators: martimiz, Sean, biapar, Willr, Ingo, swaiba, simon_w

Page: 1
Go to End
Author Topic: 772 Views
  • craesh
    Avatar
    Community Member
    25 Posts

    How do I submit patches Link to this post

    Hi!

    I developed some sites with Silverstripe and had to patch some bugs to make them work. Once I submited a patch for an already opened ticket, once I opened a ticket by myself and posted the appropriate patch.

    See here for both tickets:
    http://open.silverstripe.com/ticket/4442
    http://open.silverstripe.com/ticket/4502

    That was about 1-2 weeks ago, but there were no replies from the main developers. I don't know if they have been noticed, reviewed, accepted or even already applied to trunk. Maybe I missed something and no one knows that there are new patches awaiting some review. So how should I do that? Should I assign them to myself? Should I set the status to 'inprogress'?

    Thanks!
    craesh

  • Juanitou
    Avatar
    Community Member
    323 Posts

    Re: How do I submit patches Link to this post

    I have always got replies from developers when using Trac. I think you should add a milestone (2.3.3 or 2.4), since your tickets are not being displayed in the Roadmap because of it. Also, bugs are bugs, even if you submit a patch for it. Maybe you'll get more attention by tagging your tickets as defects.

    My two cents,
    Juan

  • craesh
    Avatar
    Community Member
    25 Posts

    Re: How do I submit patches Link to this post

    Hi Juan!

    Thanks. Lets see if it works... I've added 2.4.0 alpha as milestone for both. Isn't there a 2.3.4 planed? I don't feel 2.3.3 is as stable as I expected it to be (I've been facing 2 severe bugs in a few weeks developing sites for it), so I'd rather go and hunt some bugs (-> new revision) instead of adding features (-> new minor version). But that's another topic...

    Greetings!
    craesh

  • ajshort
    Avatar
    Community Member
    244 Posts

    Re: How do I submit patches Link to this post

    On the contrary, you should NOT add a milestone to the tickets - this is normally left up to the core developers to decide (unless you are sure that the ticket is suitable for inclusion in a specific release). Also, if it's a patch you should NOT tag it as a defect - leave it as a patch. Otherwise it won't show up in the patches report. However, tickets often do take a while to get looked at, especially since one of the core developers is currently away.

    Finally, you should probably follow existing coding standards, as none of your patches do and its a good idea to keep it consistent.

  • Willr
    Avatar
    Forum Moderator
    5490 Posts

    Re: How do I submit patches Link to this post

    That was about 1-2 weeks ago, but there were no replies from the main developers. I don't know if they have been noticed, reviewed, accepted or even already applied to trunk. Maybe I missed something and no one knows that there are new patches awaiting some review. So how should I do that? Should I assign them to myself? Should I set the status to 'inprogress'?

    We normally try and go through the tickets at soon as we can but during busy times we have 500+ open tickets so we cannot get through all of them weekly. If its been noticed or reviewed or applied to trunk then we will comment on the ticket. If your ticket has no comments or changes then it is likely we have not looked at the ticket. Also enhancements (like your tickets) are less of a priority for us to get into trunk then major defects.

    Do not set them to inprogress as that would mean that this ticket is in progress from a core dev.

  • Juanitou
    Avatar
    Community Member
    323 Posts

    Re: How do I submit patches Link to this post

    Hi!

    Thanks ajshort for explaining the guidelines, and Will for explaining how difficult is to cope with all those tickets.

    Best regards,
    Juan

    772 Views
Page: 1
Go to Top

Want to know more about the company that brought you SilverStripe? Then check out SilverStripe.com

Comments on this website? Please give feedback.