Jump to:

1156 Posts in 2568 Topics by 408 members

Upgrading SilverStripe

SilverStripe Forums » Upgrading SilverStripe » Release 2.3.4: Changeset 88281 not included?

Ask questions about upgrading SilverStripe to the latest version.

Moderators: martimiz, Sean, biapar, Willr, Ingo, swaiba, simon_w

Page: 1
Go to End
Author Topic: 912 Views
  • spassiger
    Avatar
    Community Member
    2 Posts

    Release 2.3.4: Changeset 88281 not included? Link to this post

    Good evening everybody,

    I've just downloaded the newest version (2.3.4) of SilverStripe and extracted the files. I read the changelog, too and was happy to see that a bug that caused problems with symbolic links should have been fixed in this version ([88281] BUGFIX: Ensure ASSETS_PATH is respected). This bug occured when SilverStripe was extracted into a separate directory and symbolic links to cms, jsparty and sapphire were created in the folder of the web project(s) to allow using a simple installation of SilverStripe in multiple projects. (For more information see Multiple site support? and multisites possible?)

    But after upgrading and testing my project, I encountered the same problem again. I looked into the source code of core/model/Image.php and filesystem/File.php and recognized that the changes submitted in 88281 are not included in the current stable release 2.3.4. I am a little bit confused now and it would be nice if somebody could help me - is there a mistake in the 2.3.4 ChangeLog?

  • Willr
    Avatar
    Forum Moderator
    5490 Posts

    Re: Release 2.3.4: Changeset 88281 not included? Link to this post

    It appears it was commited for 2.3.4 and then reverted in a later change - http://open.silverstripe.org/changeset/88282.

    Our changelog generator doesn't handle reverted commits it seems.

  • spassiger
    Avatar
    Community Member
    2 Posts

    Re: Release 2.3.4: Changeset 88281 not included? Link to this post

    Ah, thanks for your answer. Next time I'll look into the revision log of the affected file. ;)

    Nevertheless, can you make a prediction when this problem will be fixed? I had to correct /sapphire/core/model/Image.php (replace "../" with "Director::BaseFolder()") this time once again. But I'm not an expert with the SilverStripe source code (yet) and so I'm not sure whether this is the optimal way to do it.

    912 Views
Page: 1
Go to Top

Want to know more about the company that brought you SilverStripe? Then check out SilverStripe.com

Comments on this website? Please give feedback.