Jump to:

1131 Posts in 1965 Topics by 402 members

Upgrading SilverStripe

SilverStripe Forums » Upgrading SilverStripe » Upgrading to 2.4.1 results in 
 in HTML code

Ask questions about upgrading SilverStripe to the latest version.

Moderators: martimiz, Sean, biapar, Willr, Ingo, swaiba, simon_w

Page: 1 2
Go to End
Author Topic: 2576 Views
  • Ingo
    Avatar
    Forum Moderator
    801 Posts

    Re: Upgrading to 2.4.1 results in 
 in HTML code Link to this post

    Thanks for tracking this down Marcus - it seems to be fairly isolated to the HTMLValue class, so at least we don't have to start debugging TinyMCE. TinyMCE has a remove_linebreaks option by the way, but we shouldn't make assumptions about the editing frontend from within HTMLValue. The DOMDocument API doesn't seem to have any options to control this behaviour ("preserveWhiteSpace" doesn't seem to have an effect on this).

    I've committed your fix in http://open.silverstripe.org/changeset/111878, including a basic unit test to validate the behaviour.

  • Sean
    Avatar
    Forum Moderator
    921 Posts

    Re: Upgrading to 2.4.1 results in 
 in HTML code Link to this post

    Subsequent fix applied here which is more portable: http://open.silverstripe.org/changeset/111949/modules
    Also added a brief comment describing this change, and why it's necessary in HTMLValue.

    Previously this broke on Windows (ironically), now this works on UNIX based operating systems as well as Windows through passing unit tests.

    Cheers,
    Sean

    2576 Views
Page: 1 2
Go to Top

Want to know more about the company that brought you SilverStripe? Then check out SilverStripe.com

Comments on this website? Please give feedback.