Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

We're retiring the forums!

The SilverStripe forums have passed their heyday. They'll stick around, but will be read only. We'd encourage you to get involved in the community via the following channels instead:

All other Modules /

Discuss all other Modules here.

Moderators: martimiz, Sean, Ed, biapar, Willr, Ingo, swaiba

Newsletter - latest version github - subscription page


Go to End


3 Posts   572 Views

Avatar
Kiwipearls

Community Member, 34 Posts

19 March 2012 at 10:26am

I really love the subscription page in the latest version on Github.

But there is on error and I do not know how to fix.

When a user submits the form to subscribe, the subscription completion page has a error with two <p> tags.

I am so close to having this module working for my kid's school and would love to fix this tiny error but I do not know where to look.

I very eagerly look forward to hearing from you - as I need this site finished before Easter.

Avatar
Kiwipearls

Community Member, 34 Posts

19 March 2012 at 10:34am

I found the fix

newsletter/templates/Includes/SubscribeSubmission.ss

change

<% if FirstName %>$FirstName,<br ><% end_if %>

<p>$OnCompleteMessage</p>

to

<% if FirstName %>$FirstName,<% end_if %>

$OnCompleteMessage

Avatar
Willr

Forum Moderator, 5523 Posts

19 March 2012 at 11:39am

Would be great if you could submit that bugfix back to the github page so that it fixes it for everyone else if you haven't done it yet.