Hi all, does someone has a simple page controller extension laying around? Mine doesn't seem to work and I can't figure out why.

<?php

class PageExtension_Controller extends Extension {

    public function init() {
        parent::init();

        // Google maps API
        Requirements::javascript('https://maps.googleapis.com/maps/api/js?key=xxxxxx');

    }

}

// config.yml

Page_Controller:
  extensions:
    - PageExtension_Controller

The JS file in the extension init method is simply not loaded. Am I missing something here?

Try using contentcontrollerInit() instead of init(). That might work...

I wishfully tried that, no luck unfortunately. Doesn't change anything.

Also I ran a test to check if the controller extension is loaded it all. The extension is loaded just fine. It's just the init method that doesn't execute

Why not use onAfterInit or onBeforeInit.
This code below should work.

<?php

class PageExtension_Controller extends DataExtension{

    public function onAfterInit() {
         Requirements::javascript('https://maps.googleapis.com/maps/api/js?key=xxxxxx');
   }

@patjnr, OnAfterInit() does work, excellent!

This leaves me wondering, why does the normal Init() method not work in extensions? Is it supposed to be working for Extensions at all?

Great that patjnr helped you out! Leaves me wondering why I couldn't have come up with that. Holes in my head for sure... :(

About init I think I can explain... A DataExtension or Extension is used to add extra methods and properties to its owner. So you can't add init() because the Page_Controler already has that one covered. However Controller::init() provides an extension hook 'onAfterInit', so if you add that method instead, it will be called by the owners init() function.

That makes sense.

I've got so used to overriding methods (getCMSFields, onBeforeWrite etc) that I expected the same pattern in Extension classes

Yep, the naming is sort of confusing. Standard extended or derived classes on the one side, where you override certain methods, and the SilverStripe Extension class, which is something completely different.

It used to be called a Decorator class, which for me was much less confusing. :) It must have not quite fit the decorator pattern, for it to be renamed...