Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

We're retiring the forums!

The SilverStripe forums have passed their heyday. They'll stick around, but will be read only. We'd encourage you to get involved in the community via the following channels instead:

General Questions /

General questions about getting started with SilverStripe that don't fit in any of the categories above.

Moderators: martimiz, Sean, Ed, biapar, Willr, Ingo, swaiba

Requirements and HTML5 <header tag


Go to End


3 Posts   2218 Views

Avatar
Wilson

Community Member, 63 Posts

25 May 2010 at 6:02am

Edited: 25/05/2010 6:07am

Hi everyone,

I've just built my first HTML5 front-end and am bolting it on to SS2.4. I noticed that the required JS and CSS is written twice even though I have

Requirements::set_write_js_to_body(false);

in my _config.php

I have a suspicion that it's because my header is wrapped in the <header> tag.

Has anyone come across this before?

Thanks!
Wilson

Avatar
Wilson

Community Member, 63 Posts

25 May 2010 at 6:17am

Looks like it 688 and 689 in Requirements.php. I'll see if this bug has been logged.

Avatar
Willr

Forum Moderator, 5523 Posts

25 May 2010 at 11:28pm

Good point. I think it appends it to </head rather than </head> so </head will match both your elements. Should be a simple fix for the Requirements class to use </head> rather than </head OR just use the first </head.