Skip to main content

This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.

All other Modules /

Discuss all other Modules here.

Moderators: martimiz, Sean, biapar, Willr, Ingo, swaiba, simon_w

Bug Fix in Sapphire MySQL Search Engine


Reply


2 Posts   1135 Views

Avatar
lubzee

Community Member, 15 Posts

13 October 2009 at 3:59am

Hi

I've created a ticket #4508 for an issue with the MySQL search engine of Sapphire. Basically, the Menu Title of pages are not returned with the Search results. This means that pages are only listed with their Page Title and not the Menu Title which may differ. For my particular site, I wanted the more descriptive Menu Titles to be displayed.

I've submitted a patch with my ticket that adds the Menu Title to the results array that is returned. However my ticket was closed without the patch being implemented or any change in the MySQL search engine.

I would like to know why this wouldn't be a substantial enhancement or even a bug fix and why it wouldn't be included in the later revisions? I don't see it as Custom Functionality since Menu Title is truly a property of SiteTree objects and should be a valid field to have access to for the search function?

Unfortunately I now have a Sapphire repo that is out of sync on that one file sapphire/core/model/MySQLDatabase.php

It would be great to have this included in the Head Revision so that I don't have to extend this whole class & function just to enable a feature that should be there IMHO.

ticket:
http://open.silverstripe.com/ticket/4508
patch:
http://open.silverstripe.com/attachment/ticket/4508/MySQLDatabase_Search.patch

Kind regards
Lubzee

Avatar
Willr

Forum Moderator, 5513 Posts

13 October 2009 at 4:35pm

Your ticket wasn't closed, just the 2.3.3 milestone deleted.

Please do not add milestones, the core devs use this to assign what tickets go into what release and 2.3.3 was for security and other critical fixes not features / enhancements.