I found XSS in search module:
Combining it with CSRF could be harmful.
This site requires you to update your browser. Your browsing experience maybe affected by not having the most up to date version.
Please use forum.silverstripe.org for any new questions
(announcement).
The forum archive will stick around, but will be read only.
You can also use our Slack channel
or StackOverflow to ask for help.
Check out our community overview for more options to contribute.
I found XSS in search module:
Combining it with CSRF could be harmful.
Thanks very much for pointing this out mateusz, its immensely helpful for people to be notifying us of security issues like this! Sean has looked into this and fixed it yesterday, so it is available for download in our daily builds. It has been escalated to be included in our 2.0.1 release too, hence we just built 2.0.1rc4 ...
patch:
search/SearchForm.php (revision 33165)
public function getSearchQuery() {
- return $_REQUEST['Search'];
+ return Convert::raw2xml($_REQUEST['Search']);
}